From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtZAs-0000ya-An for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtZAq-0003l2-Hu for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:10 -0500 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:59970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtZAp-0003kn-Tw for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:08 -0500 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Jan 2013 13:05:36 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 11BA7394004E for ; Fri, 11 Jan 2013 13:06:56 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0B7aseT23199766 for ; Fri, 11 Jan 2013 13:06:54 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0B7atR6014947 for ; Fri, 11 Jan 2013 18:36:55 +1100 Message-ID: <50EFC115.30208@linux.vnet.ibm.com> Date: Fri, 11 Jan 2013 15:36:53 +0800 From: Lei Li MIME-Version: 1.0 References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> <50EB1B8E.6080509@redhat.com> In-Reply-To: <50EB1B8E.6080509@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/3] Time resync support by qemu-ga List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 01/08/2013 03:01 AM, Eric Blake wrote: > On 01/06/2013 03:06 AM, Lei Li wrote: >> This patch series attempts to add time resync support >> to qemu-ga by introducing qemu-ga commands guest-get-time >> and guest-set-time. >> >> The interface for these commands like: >> >> { 'command': 'guest-get-time', 'returns': 'HostTimeInfo' } >> >> { 'command': 'guest-set-time', >> 'data': { '*seconds': 'int', '*microseconds': 'int', >> '*utc-offset': 'int' } } > Why are these fields marked optional? I guess I'll find out in the > actual patch, but at first glance, I think all three would be mandatory. > >> TODO: >> This is a RFC version with POSIX-specific command implemented. >> I just test on Linux guest, will add win32-specific command to >> support Windows guest later. Since I want to make sure if this >> seems like the way we should be headed. > I hope that you just meant that you are lacking a win32 implementation > of the command, but that when it is implemented, it will still use the > same interface. That is, even though windows itself doesn't use POSIX > time, and has a different Epoch than Jan 1 1970, such differences should > be transparent to the user, who should always pass a POSIX timestamp > through the interface. What we don't want is two different commands, > where the management app then has to know whether the guest is Unix or > Windows based, to know which of the two commands to send. Yes, I mean that there is win32 implementation of this command lacking. And thanks for your reminder of the differences for the Epoch between Linux and Windows. -- Lei