Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

[Lei Li <lilei@linux.vnet.ibm.com>]

On 01/08/2013 06:04 AM, Eric Blake wrote:
> On 01/06/2013 03:06 AM, Lei Li wrote:
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>>   qga/commands-posix.c |   12 ++++++++++++
>>   qga/qapi-schema.json |   17 +++++++++++++++++
>>   2 files changed, 29 insertions(+), 0 deletions(-)
>>
>> +++ b/qga/qapi-schema.json
>> @@ -100,6 +100,23 @@
>>                'utc-offset': 'int' } }
>>   
>>   ##
>> +# @guest-get-time:
>> +#
>> +# Get the information about host time in UTC and the
>> +# UTC offset.
> About the host time, or about the guest time?  In other words, doesn't
> this command exist for the host to ask the guest what time the _guest_
> thinks it is, so that the host can then decide whether to issue a
> followup command to tell the guest to adjust its time?

No, this command is for getting host time. You might want to take a look at
the RFC and the reply from Mike I sent few days ago for suggestions and
discussions.

http://article.gmane.org/gmane.comp.emulators.qemu/186126

>> +#
>> +# This command tries to get the host time which is
>> +# presumably correct, since need to be able to resynchronize
>> +# clock to host in guest.
>> +#
>> +# Returns: @HostTimeInfo on success.
> For that matter, should we name the type in patch 1/3 'TimeInfo',
> instead of 'HostTimeInfo', as it is not intrinsically tied to host or
> guest, but more a function of who is being queried?

Yes, it make sense. Luiz feel confused about this 'HostTimeInfo' too,
I think 'TimeInfo' might be a good idea. :)



-- 
Lei