From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtZBK-0001qU-44 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtZBH-0003nm-JG for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:38 -0500 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:54863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtZBG-0003nP-TI for qemu-devel@nongnu.org; Fri, 11 Jan 2013 02:37:35 -0500 Received: from /spool/local by e28smtp04.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 11 Jan 2013 13:06:16 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 5F72BE004D for ; Fri, 11 Jan 2013 13:07:44 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0B7bQqx65274052 for ; Fri, 11 Jan 2013 13:07:26 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0B7bRJN017437 for ; Fri, 11 Jan 2013 18:37:27 +1100 Message-ID: <50EFC136.8000308@linux.vnet.ibm.com> Date: Fri, 11 Jan 2013 15:37:26 +0800 From: Lei Li MIME-Version: 1.0 References: <1357466820-12860-1-git-send-email-lilei@linux.vnet.ibm.com> <1357466820-12860-3-git-send-email-lilei@linux.vnet.ibm.com> <50EB4676.6030208@redhat.com> In-Reply-To: <50EB4676.6030208@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com On 01/08/2013 06:04 AM, Eric Blake wrote: > On 01/06/2013 03:06 AM, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> qga/commands-posix.c | 12 ++++++++++++ >> qga/qapi-schema.json | 17 +++++++++++++++++ >> 2 files changed, 29 insertions(+), 0 deletions(-) >> >> +++ b/qga/qapi-schema.json >> @@ -100,6 +100,23 @@ >> 'utc-offset': 'int' } } >> >> ## >> +# @guest-get-time: >> +# >> +# Get the information about host time in UTC and the >> +# UTC offset. > About the host time, or about the guest time? In other words, doesn't > this command exist for the host to ask the guest what time the _guest_ > thinks it is, so that the host can then decide whether to issue a > followup command to tell the guest to adjust its time? No, this command is for getting host time. You might want to take a look at the RFC and the reply from Mike I sent few days ago for suggestions and discussions. http://article.gmane.org/gmane.comp.emulators.qemu/186126 >> +# >> +# This command tries to get the host time which is >> +# presumably correct, since need to be able to resynchronize >> +# clock to host in guest. >> +# >> +# Returns: @HostTimeInfo on success. > For that matter, should we name the type in patch 1/3 'TimeInfo', > instead of 'HostTimeInfo', as it is not intrinsically tied to host or > guest, but more a function of who is being queried? Yes, it make sense. Luiz feel confused about this 'HostTimeInfo' too, I think 'TimeInfo' might be a good idea. :) -- Lei