From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttbzf-00056l-2E for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:37:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttbzd-0003Li-Iq for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:37:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39662) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttbzd-0003L5-Ar for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:37:45 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BAbikC030930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Jan 2013 05:37:44 -0500 Message-ID: <50EFEB76.9080702@redhat.com> Date: Fri, 11 Jan 2013 11:37:42 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1357827786-14624-1-git-send-email-kraxel@redhat.com> <1357827786-14624-7-git-send-email-kraxel@redhat.com> <50EF1799.80303@redhat.com> In-Reply-To: <50EF1799.80303@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org >> ## +# @ChardevFile: > > Should you mention '@in: #optional' and '@out:' in any further > detail? Done. > Hmm; here you document ChardevFile as a separate type, but you > didn't document ChardevDummy in patch 4/10. As the name says it is just a dummy passed when the backend in question doesn't need any parameters. Therefore it is empty. Does it really need its own documentation stanza? cheers, Gerd