qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 07/10] chardev: add serial chardev support to chardev-add (qmp)
Date: Fri, 11 Jan 2013 11:46:02 +0100	[thread overview]
Message-ID: <50EFED6A.6030307@redhat.com> (raw)
In-Reply-To: <50EF1903.7040301@redhat.com>

On 01/10/13 20:39, Eric Blake wrote:
> On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
>> Simliar to file, except that no separate in/out files are
>> supported
> 
> s/Simliar/Similar/

Fixed.

>> +        socket_set_nonblock(fd);
> 
> Can this fail?

No.

cheers,
  Gerd

  reply	other threads:[~2013-01-11 10:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-10 14:22 [Qemu-devel] [PATCH v2 00/10] chardev hotplug patch series Gerd Hoffmann
2013-01-10 14:22 ` [Qemu-devel] [PATCH v2 01/10] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2013-01-10 18:34   ` Eric Blake
2013-01-10 14:22 ` [Qemu-devel] [PATCH v2 02/10] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2013-01-10 18:35   ` Eric Blake
2013-01-10 14:22 ` [Qemu-devel] [PATCH v2 03/10] chardev: reduce chardev ifdef mess a bit Gerd Hoffmann
2013-01-10 18:35   ` Eric Blake
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 04/10] chardev: add qmp hotplug commands, with null chardev support Gerd Hoffmann
2013-01-10 18:40   ` Eric Blake
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 05/10] chardev: add hmp hotplug commands Gerd Hoffmann
2013-01-10 18:42   ` Eric Blake
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 06/10] chardev: add file chardev support to chardev-add (qmp) Gerd Hoffmann
2013-01-10 19:33   ` Eric Blake
2013-01-11 10:37     ` Gerd Hoffmann
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 07/10] chardev: add serial " Gerd Hoffmann
2013-01-10 19:39   ` Eric Blake
2013-01-11 10:46     ` Gerd Hoffmann [this message]
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 08/10] chardev: add parallel " Gerd Hoffmann
2013-01-10 19:41   ` Eric Blake
2013-01-11 10:53     ` Gerd Hoffmann
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 09/10] chardev: add socket " Gerd Hoffmann
2013-01-10 19:43   ` Eric Blake
2013-01-10 14:23 ` [Qemu-devel] [PATCH v2 10/10] chardev: add pty " Gerd Hoffmann
2013-01-10 19:45   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50EFED6A.6030307@redhat.com \
    --to=kraxel@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).