From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57215)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ttc7n-0007NB-9t
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:46:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ttc7h-000626-Fy
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:46:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16465)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Ttc7h-00061u-8H
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:46:05 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BAk4CX014888
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 05:46:04 -0500
Message-ID: <50EFED6A.6030307@redhat.com>
Date: Fri, 11 Jan 2013 11:46:02 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1357827786-14624-1-git-send-email-kraxel@redhat.com>
	<1357827786-14624-8-git-send-email-kraxel@redhat.com>
	<50EF1903.7040301@redhat.com>
In-Reply-To: <50EF1903.7040301@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 07/10] chardev: add serial chardev
 support to chardev-add (qmp)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/10/13 20:39, Eric Blake wrote:
> On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
>> Simliar to file, except that no separate in/out files are
>> supported
> 
> s/Simliar/Similar/

Fixed.

>> +        socket_set_nonblock(fd);
> 
> Can this fail?

No.

cheers,
  Gerd