Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev support to chardev-add (qmp)

[Gerd Hoffmann <kraxel@redhat.com>]

On 01/10/13 20:41, Eric Blake wrote:
> On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
>> Also alias the old parport name to parallel for -chardev.
>> 
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- 
>> qapi-schema.json |    3 ++- qemu-char.c      |   44
>> ++++++++++++++++++++++++++++---------------- qemu-options.hx  |
>> 5 ++++- 3 files changed, 34 insertions(+), 18 deletions(-)
>> 
> 
>> ## -{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] } +{
>> 'enum': 'ChardevPortKind', 'data': [ 'serial', +
>> 'parallel' ] }
>> 
>> { 'type': 'ChardevPort', 'data': { 'device' : 'str', 'type'   :
>> 'ChardevPortKind'} }
> 
> In patch 7, should the enum and type have separate documentation?

IMHO no, they belong together as ChardevPortKind is only used by
ChardevPort.

cheers,
  Gerd