From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59305)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtcEz-0000rt-Jd
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:53:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtcEy-0007sK-3x
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:53:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TtcEx-0007sE-SX
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 05:53:36 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BArYiL010802
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 05:53:34 -0500
Message-ID: <50EFEF2C.6040000@redhat.com>
Date: Fri, 11 Jan 2013 11:53:32 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1357827786-14624-1-git-send-email-kraxel@redhat.com>
	<1357827786-14624-9-git-send-email-kraxel@redhat.com>
	<50EF1977.9020709@redhat.com>
In-Reply-To: <50EF1977.9020709@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 08/10] chardev: add parallel chardev
 support to chardev-add (qmp)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/10/13 20:41, Eric Blake wrote:
> On 01/10/2013 07:23 AM, Gerd Hoffmann wrote:
>> Also alias the old parport name to parallel for -chardev.
>> 
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> --- 
>> qapi-schema.json |    3 ++- qemu-char.c      |   44
>> ++++++++++++++++++++++++++++---------------- qemu-options.hx  |
>> 5 ++++- 3 files changed, 34 insertions(+), 18 deletions(-)
>> 
> 
>> ## -{ 'enum': 'ChardevPortKind', 'data': [ 'serial' ] } +{
>> 'enum': 'ChardevPortKind', 'data': [ 'serial', +
>> 'parallel' ] }
>> 
>> { 'type': 'ChardevPort', 'data': { 'device' : 'str', 'type'   :
>> 'ChardevPortKind'} }
> 
> In patch 7, should the enum and type have separate documentation?

IMHO no, they belong together as ChardevPortKind is only used by
ChardevPort.

cheers,
  Gerd