From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests
Date: Fri, 11 Jan 2013 14:28:17 +0100 [thread overview]
Message-ID: <50F01371.2070709@redhat.com> (raw)
In-Reply-To: <1357907697-16790-4-git-send-email-stefanha@redhat.com>
Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
> + iov = &bounce_iov;
> + iov_cnt = 1;
> +
> + if (read) {
> + /* Need to copy back from bounce buffer on completion */
> + read_qiov = g_slice_new(QEMUIOVector);
> + qemu_iovec_init(read_qiov, iov_cnt);
> + qemu_iovec_concat_iov(read_qiov, iov, iov_cnt, 0, qiov.size);
This is still wrong, how did you test it?
Paolo
next prev parent reply other threads:[~2013-01-11 13:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 12:34 [Qemu-devel] [PATCH v2 0/3] dataplane: misaligned buffers support for Windows guests Stefan Hajnoczi
2013-01-11 12:34 ` [Qemu-devel] [PATCH v2 1/3] block: make qiov_is_aligned() public Stefan Hajnoczi
2013-01-11 12:34 ` [Qemu-devel] [PATCH v2 2/3] dataplane: extract virtio-blk read/write processing into do_rdwr_cmd() Stefan Hajnoczi
2013-01-11 12:34 ` [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests Stefan Hajnoczi
2013-01-11 13:28 ` Paolo Bonzini [this message]
2013-01-11 14:40 ` Stefan Hajnoczi
2013-01-11 15:50 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F01371.2070709@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).