From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37377)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tteen-00083x-Gh
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:28:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tteej-0008Lc-SV
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:28:25 -0500
Received: from mail-qa0-f54.google.com ([209.85.216.54]:46627)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tteej-0008LY-NG
	for qemu-devel@nongnu.org; Fri, 11 Jan 2013 08:28:21 -0500
Received: by mail-qa0-f54.google.com with SMTP id j15so1460478qaq.13
	for <qemu-devel@nongnu.org>; Fri, 11 Jan 2013 05:28:21 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50F01371.2070709@redhat.com>
Date: Fri, 11 Jan 2013 14:28:17 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1357907697-16790-1-git-send-email-stefanha@redhat.com>
	<1357907697-16790-4-git-send-email-stefanha@redhat.com>
In-Reply-To: <1357907697-16790-4-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned
	virtio-blk requests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
> +        iov = &bounce_iov;
> +        iov_cnt = 1;
> +
> +        if (read) {
> +            /* Need to copy back from bounce buffer on completion */
> +            read_qiov = g_slice_new(QEMUIOVector);
> +            qemu_iovec_init(read_qiov, iov_cnt);
> +            qemu_iovec_concat_iov(read_qiov, iov, iov_cnt, 0, qiov.size);

This is still wrong, how did you test it?

Paolo