From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtgCt-00046u-Nn for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:07:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtgCq-0002jz-8O for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:07:43 -0500 Received: from smtp.citrix.com ([66.165.176.89]:1524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtgCq-0002jn-2s for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:07:40 -0500 Message-ID: <50F02A16.7000603@citrix.com> Date: Fri, 11 Jan 2013 15:04:54 +0000 From: Julien Grall MIME-Version: 1.0 References: <1357895886-14283-1-git-send-email-stefanha@redhat.com> <1357895886-14283-7-git-send-email-stefanha@redhat.com> In-Reply-To: <1357895886-14283-7-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Anthony Liguori , "qemu-devel@nongnu.org" , =?ISO-8859-1?Q?Andreas_F=E4rber?= From: Julien Grall The commit 258711 introduced MemoryRegion to replace ioport_region* for ioport 80h and F0h. A MemoryRegion needs to have both read and write callback otherwise a segfault will occur when an access is made. The previous behaviour of this both ioport is to return 0xffffffffffffffff. So keep this behaviour. Reported-by: Adam Lackorzynski Signed-off-by: Julien Grall Tested-by: Adam Lackorzynski Signed-off-by: Stefan Hajnoczi --- hw/pc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/pc.c b/hw/pc.c index df0c48e..90b1bf7 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -103,6 +103,11 @@ static void ioport80_write(void *opaque, hwaddr addr, uint64_t data, { } +static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned size) +{ + return 0xffffffffffffffffULL; +} + /* MSDOS compatibility mode FPU exception support */ static qemu_irq ferr_irq; @@ -123,6 +128,11 @@ static void ioportF0_write(void *opaque, hwaddr addr, uint64_t data, qemu_irq_lower(ferr_irq); } +static uint64_t ioportF0_read(void *opaque, hwaddr addr, unsigned size) +{ + return 0xffffffffffffffffULL; +} + /* TSC handling */ uint64_t cpu_get_tsc(CPUX86State *env) { @@ -960,6 +970,7 @@ static void cpu_request_exit(void *opaque, int irq, int level) static const MemoryRegionOps ioport80_io_ops = { .write = ioport80_write, + .read = ioport80_read, .endianness = DEVICE_NATIVE_ENDIAN, .impl = { .min_access_size = 1, @@ -969,6 +980,7 @@ static const MemoryRegionOps ioport80_io_ops = { static const MemoryRegionOps ioportF0_io_ops = { .write = ioportF0_write, + .read = ioportF0_read, .endianness = DEVICE_NATIVE_ENDIAN, .impl = { .min_access_size = 1, -- 1.8.0.2