From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtgN1-0006LN-PU for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:18:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtgMv-0005Ek-Nw for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:18:11 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38088 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtgMv-00059D-Hw for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:18:05 -0500 Message-ID: <50F02D00.6080301@suse.de> Date: Fri, 11 Jan 2013 16:17:20 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1357895886-14283-1-git-send-email-stefanha@redhat.com> <1357895886-14283-7-git-send-email-stefanha@redhat.com> <50EFFC7F.8090606@suse.de> <50F02761.6030707@citrix.com> In-Reply-To: <50F02761.6030707@citrix.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] hw/pc.c: Fix converting of ioport_register* to MemoryRegion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Julien Grall Cc: Anthony Liguori , "qemu-devel@nongnu.org" , Stefan Hajnoczi Am 11.01.2013 15:53, schrieb Julien Grall: > On 01/11/2013 11:50 AM, Andreas F=E4rber wrote: >> Am 11.01.2013 10:18, schrieb Stefan Hajnoczi: >>> @@ -103,6 +103,11 @@ static void ioport80_write(void *opaque, hwaddr = addr, uint64_t data, >>> { >>> } >>> =20 >>> +static uint64_t ioport80_read(void *opaque, hwaddr addr, unsigned si= ze) >>> +{ >>> + return 0xffffffffffffffff; >> >> Might these require ULL for i386? >=20 > Indeed. I will resend a patch with ULL for ioport80_read and ioportF0_r= ead. Since this patch is already in a pull and Anthony indicated it is being processed, can you fix this as a follow-up patch instead? Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg