From: Wolfgang Mauerer <wolfgang.mauerer@siemens.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: "peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"paul@codesourcery.com" <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Realview/Versatile: Export LED state
Date: Fri, 11 Jan 2013 16:46:05 +0100 [thread overview]
Message-ID: <50F033BD.5060907@siemens.com> (raw)
In-Reply-To: <50F0287C.1010708@suse.de>
Hello,
On 11/01/13 15:58, Andreas Färber wrote:
>> @@ -386,6 +406,10 @@ static int arm_sysctl_init(SysBusDevice *dev)
>> > {
>> > arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, dev);
>> >
>> > + s->display = qemu_chr_new("leds0", "chardev:leds", NULL);
>> > + if (s->display) {
> Can this ever be NULL?
if can be NULL if no leds chardev is available.
Best, Wolfgang
next prev parent reply other threads:[~2013-01-11 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 13:42 [Qemu-devel] [PATCH] Realview/Versatile: Export LED state Wolfgang Mauerer
2013-01-11 14:58 ` Andreas Färber
2013-01-11 15:46 ` Wolfgang Mauerer [this message]
2013-01-11 15:00 ` Peter Maydell
2013-01-11 15:23 ` Andreas Färber
2013-01-11 15:44 ` Wolfgang Mauerer
2013-01-11 20:22 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F033BD.5060907@siemens.com \
--to=wolfgang.mauerer@siemens.com \
--cc=afaerber@suse.de \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).