From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtgvA-0001iE-TD for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:53:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ttgv5-0006Ql-SO for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:53:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ttgv5-0006Qh-L1 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 10:53:23 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BFrNgO013937 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Jan 2013 10:53:23 -0500 Message-ID: <50F034AB.6070507@redhat.com> Date: Fri, 11 Jan 2013 16:50:03 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1357907697-16790-1-git-send-email-stefanha@redhat.com> <1357907697-16790-4-git-send-email-stefanha@redhat.com> <50F01371.2070709@redhat.com> <20130111144046.GB2310@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20130111144046.GB2310@stefanha-thinkpad.muc.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] dataplane: handle misaligned virtio-blk requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paolo Bonzini , qemu-devel@nongnu.org Am 11.01.2013 15:40, schrieb Stefan Hajnoczi: > On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote: >> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto: >>> + iov = &bounce_iov; >>> + iov_cnt = 1; >>> + >>> + if (read) { >>> + /* Need to copy back from bounce buffer on completion */ >>> + read_qiov = g_slice_new(QEMUIOVector); >>> + qemu_iovec_init(read_qiov, iov_cnt); >>> + qemu_iovec_concat_iov(read_qiov, iov, iov_cnt, 0, qiov.size); >> >> This is still wrong, how did you test it? > > I sent it before reading the reviews from you and Kevin. Bizarrely > Windows saw the files I copied to the disk - even across reboot (no > buffer cache involved?). Or is Windows 8 doing tricks like "shutdown" > is actually "suspend to disk"? As far as I know this is exactly what it's doing. I've seen warnings that you shouldn't mount file systems of a dual-boot Windows 8 if you didn't change its options so that it really shuts down. Kevin