From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44849) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tth1y-00061e-1d for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:00:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tth1n-0000LR-Lw for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:00:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:39812 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tth1n-0000I6-Ff for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:00:19 -0500 Message-ID: <50F03705.8020401@suse.de> Date: Fri, 11 Jan 2013 17:00:05 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1355106144-30846-1-git-send-email-lig.fnst@cn.fujitsu.com> <1357868842.1212.4.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1357868842.1212.4.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bit in dr7 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Peter Maydell , imammedo@redhat.com, Jan Kiszka , qemu-devel@nongnu.org, ehabkost@redhat.com Hi Guang, Am 11.01.2013 02:47, schrieb li guang: > can these patches get an ack from you? I'm waiting on feedback from the previous reviewers... CC'ing. > or they were obsoleted? No, I don't spot any need to rebase. However, patch 3/3 is tab-damaged, please run scripts/checkpatch.pl. That can be automated as a git hook. Regards, Andreas > =E5=9C=A8 2012-12-10=E4=B8=80=E7=9A=84 10:22 +0800=EF=BC=8Cliguang=E5=86= =99=E9=81=93=EF=BC=9A >> Signed-off-by: liguang >> --- >> target-i386/cpu.h | 7 +++++++ >> 1 files changed, 7 insertions(+), 0 deletions(-) >> >> diff --git a/target-i386/cpu.h b/target-i386/cpu.h >> index 90ef1ff..29245d1 100644 >> --- a/target-i386/cpu.h >> +++ b/target-i386/cpu.h >> @@ -231,6 +231,13 @@ >> #define DR7_TYPE_SHIFT 16 >> #define DR7_LEN_SHIFT 18 >> #define DR7_FIXED_1 0x00000400 >> +#define DR7_LOCAL_BP_MASK 0x55 >> +#define DR7_MAX_BP 4 >> +#define DR7_TYPE_BP_INST 0x0 >> +#define DR7_TYPE_DATA_WR 0x1 >> +#define DR7_TYPE_IO_RW 0x2 >> +#define DR7_TYPE_DATA_RW 0x3 >> + >> =20 >> #define PG_PRESENT_BIT 0 >> #define PG_RW_BIT 1 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg