From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TthC4-0001ry-85 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:10:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TthC1-0002uV-Li for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:10:56 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40375 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TthC1-0002uI-16 for qemu-devel@nongnu.org; Fri, 11 Jan 2013 11:10:53 -0500 Message-ID: <50F03988.3000603@suse.de> Date: Fri, 11 Jan 2013 17:10:48 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1355106144-30846-1-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: <1355106144-30846-1-git-send-email-lig.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/3] target-i386:define name of breakpoint bit in dr7 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: liguang Cc: Peter Maydell , imammedo@redhat.com, Jan Kiszka , ehabkost@redhat.com, qemu-devel@nongnu.org Am 10.12.2012 03:22, schrieb liguang: > Signed-off-by: liguang For a patch series consisting of more than 1 patch, please use a cover letter (e.g., --cover-letter) that details the change history of the versions. That also facilitates commenting on the series vs. a single pat= ch. > --- > target-i386/cpu.h | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index 90ef1ff..29245d1 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h > @@ -231,6 +231,13 @@ > #define DR7_TYPE_SHIFT 16 > #define DR7_LEN_SHIFT 18 > #define DR7_FIXED_1 0x00000400 > +#define DR7_LOCAL_BP_MASK 0x55 > +#define DR7_MAX_BP 4 > +#define DR7_TYPE_BP_INST 0x0 > +#define DR7_TYPE_DATA_WR 0x1 > +#define DR7_TYPE_IO_RW 0x2 > +#define DR7_TYPE_DATA_RW 0x3 > + > =20 > #define PG_PRESENT_BIT 0 > #define PG_RW_BIT 1 These defines are being introduced but not used in this patch yet. If you were to replace, e.g., 4 -> DR7_MAX_BP in this patch instead of patch 3/3, I would see a value in cherry-picking it. Assuming there is agreement on that name, of course. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg