From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 09/10] chardev: add socket chardev support to chardev-add (qmp)
Date: Fri, 11 Jan 2013 10:34:21 -0700 [thread overview]
Message-ID: <50F04D1D.1080406@redhat.com> (raw)
In-Reply-To: <1357903219-10532-10-git-send-email-kraxel@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On 01/11/2013 04:20 AM, Gerd Hoffmann wrote:
> qemu_chr_open_socket is splitted into two functions. All initialization
> after creating the socket file handler is splitted away into the new
You still haven't incorporated my fix of s/splitted/split/g that I
raised against both v1 and v2.
> @@ -2458,10 +2536,7 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
> if (!is_listen)
> is_waitconnect = 0;
>
> - chr = g_malloc0(sizeof(CharDriverState));
> - s = g_malloc0(sizeof(TCPCharDriver));
> -
> - if (is_unix) {
> + if (is_unix) {
And you still have a spurious mis-indentation here. What's going on?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2013-01-11 17:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 11:20 [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 01/10] chardev: add error reporting for qemu_chr_new_from_opts Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 02/10] chardev: fix QemuOpts lifecycle Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 03/10] chardev: reduce chardev ifdef mess a bit Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 04/10] chardev: add qmp hotplug commands, with null chardev support Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 05/10] chardev: add hmp hotplug commands Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 06/10] chardev: add file chardev support to chardev-add (qmp) Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 07/10] chardev: add serial " Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 08/10] chardev: add parallel " Gerd Hoffmann
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 09/10] chardev: add socket " Gerd Hoffmann
2013-01-11 17:34 ` Eric Blake [this message]
2013-01-14 11:35 ` [Qemu-devel] [PATCH v4 9/10] " Gerd Hoffmann
2013-01-14 21:36 ` Eric Blake
2013-01-11 11:20 ` [Qemu-devel] [PATCH v3 10/10] chardev: add pty " Gerd Hoffmann
2013-01-11 17:35 ` [Qemu-devel] [PATCH v3 00/10] chardev hotplug patch series Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F04D1D.1080406@redhat.com \
--to=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).