From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtiUv-0006eQ-6Y for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TtiUq-0000s8-0x for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TtiUp-0000rT-OE for qemu-devel@nongnu.org; Fri, 11 Jan 2013 12:34:23 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0BHYM7S013045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 Jan 2013 12:34:22 -0500 Message-ID: <50F04D1D.1080406@redhat.com> Date: Fri, 11 Jan 2013 10:34:21 -0700 From: Eric Blake MIME-Version: 1.0 References: <1357903219-10532-1-git-send-email-kraxel@redhat.com> <1357903219-10532-10-git-send-email-kraxel@redhat.com> In-Reply-To: <1357903219-10532-10-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig2FC9D2EC5CFB6AA638A7399B" Subject: Re: [Qemu-devel] [PATCH v3 09/10] chardev: add socket chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2FC9D2EC5CFB6AA638A7399B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/11/2013 04:20 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is splitted into two functions. All initializatio= n > after creating the socket file handler is splitted away into the new You still haven't incorporated my fix of s/splitted/split/g that I raised against both v1 and v2. > @@ -2458,10 +2536,7 @@ static CharDriverState *qemu_chr_open_socket(Qem= uOpts *opts) > if (!is_listen) > is_waitconnect =3D 0; > =20 > - chr =3D g_malloc0(sizeof(CharDriverState)); > - s =3D g_malloc0(sizeof(TCPCharDriver)); > - > - if (is_unix) { > + if (is_unix) { And you still have a spurious mis-indentation here. What's going on? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig2FC9D2EC5CFB6AA638A7399B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ8E0dAAoJEKeha0olJ0NqXRkIAJ6kOq4OhPEC20YwgGNsvep6 z6BLTF1ZVza+ZOz92ef1MLhDpGLzx+dkaWUCjoE7TGnf3zlvxWoVtJyvqjt/bvWv 1JeiB0l06lsQTlfYOy0X02p1ZLCEAgxH5pEwvvl9d2+hW5nd3bN9Zl45KMiujMGC QP3riHo9Z0f2UlPFSF7/S7JDBixfn2u3/LnTwN8sLzTShFkNG+KFpoccyt3Xavu6 2k72V7EAWzNXuUK/K6aYaBC8PIKc8YlI4I0eJ8W13gIRmW6TwiZLEAjTi9QDst4x /LJ/r325202jThqGuLH21x8i4KRK0gnG4C03Q3TpX2c6tKVnT3Bq+E0XqcWTKRQ= =4H/5 -----END PGP SIGNATURE----- --------------enig2FC9D2EC5CFB6AA638A7399B--