From: "Andreas Färber" <afaerber@suse.de>
To: Alberto Garcia <agarcia@igalia.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v5 1/2] Add TEWS TPCI200 IndustryPack emulation
Date: Fri, 11 Jan 2013 21:28:48 +0100 [thread overview]
Message-ID: <50F07600.1070100@suse.de> (raw)
In-Reply-To: <b508e0d83ba3a194e4e995a6bfb4052760e1d737.1357924486.git.agarcia@igalia.com>
Am 11.01.2013 18:25, schrieb Alberto Garcia:
> The TPCI200 is a PCI board that supports up to 4 IndustryPack modules.
>
> A new bus type called 'IndustryPack' has been created so any
> compatible module can be attached to this board.
>
> Signed-off-by: Alberto Garcia <agarcia@igalia.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
I do wonder if adjust_value() can be replaced by switching MemoryRegion
endianness between DEVICE_LITTLE_ENDIAN and DEVICE_BIG_ENDIAN rather
than having it as DEVICE_NATIVE_ENDIAN and doing a manual bswap16()?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2013-01-11 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 17:25 [Qemu-devel] [PATCH v5 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation Alberto Garcia
2013-01-11 17:25 ` [Qemu-devel] [PATCH v5 1/2] Add TEWS TPCI200 " Alberto Garcia
2013-01-11 20:28 ` Andreas Färber [this message]
2013-01-15 2:45 ` Alberto Garcia
2013-01-11 17:25 ` [Qemu-devel] [PATCH v5 2/2] Add GE IP-Octal 232 " Alberto Garcia
2013-01-14 20:40 ` [Qemu-devel] [PATCH v5 0/2] Add TPCI200 and " Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F07600.1070100@suse.de \
--to=afaerber@suse.de \
--cc=agarcia@igalia.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).