From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33884)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu3UU-00024v-QR
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 10:59:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu3UO-0008IL-EQ
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 10:59:26 -0500
Received: from cantor2.suse.de ([195.135.220.15]:47970 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Tu3UO-00085I-84
	for qemu-devel@nongnu.org; Sat, 12 Jan 2013 10:59:20 -0500
Message-ID: <50F18829.9050009@suse.de>
Date: Sat, 12 Jan 2013 16:58:33 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1357334986-13941-1-git-send-email-hpoussin@reactos.org>
	<1357334986-13941-5-git-send-email-hpoussin@reactos.org>
	<50EEF938.9000309@suse.de> <50EF16DB.6010606@reactos.org>
	<CAAu8pHt4Xo2130M8Z20LK3Gedbupf_3EOQ=HHyq1F7cinXw9Yw@mail.gmail.com>
In-Reply-To: <CAAu8pHt4Xo2130M8Z20LK3Gedbupf_3EOQ=HHyq1F7cinXw9Yw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 04/10] sun4u: create VGA card after ISA bus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>, qemu-devel@nongnu.org

Am 12.01.2013 12:42, schrieb Blue Swirl:
> On Thu, Jan 10, 2013 at 7:30 PM, Herv=C3=A9 Poussineau <hpoussin@reacto=
s.org> wrote:
>> Andreas F=C3=A4rber a =C3=A9crit :
>>
>>> Am 04.01.2013 22:29, schrieb Herv=C3=A9 Poussineau:
>>>>
>>>> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
>>>> ---
>>>>  hw/sun4u.c |    3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>>
>>> Doesn't look wrong to me, cc'ing Blue. I figure this is for 07/10,
>>> which switches to isa_register_portio_list().
>>
>>
>> Indeed.
>> ISA bus is created in pci_ebus_init(). VGA card registers some ISA I/O
>> ports, so an ISA bus must be present.
>=20
> OK by me.

Thanks, applied to memory-ioport branch (with an additional explanatory
sentence in the commit message):
https://github.com/afaerber/qemu-cpu/commits/memory-ioport

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg