From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tu3YM-0003FH-QH for qemu-devel@nongnu.org; Sat, 12 Jan 2013 11:03:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tu3YK-00013K-4q for qemu-devel@nongnu.org; Sat, 12 Jan 2013 11:03:26 -0500 Message-ID: <50F18947.80304@suse.de> Date: Sat, 12 Jan 2013 17:03:19 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1357334986-13941-1-git-send-email-hpoussin@reactos.org> <1357334986-13941-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1357334986-13941-2-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 01/10] ppc/newworld: add ISA bus, required by VGA card List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , Alexander Graf Cc: qemu-ppc , qemu-devel@nongnu.org Am 04.01.2013 22:29, schrieb Herv=C3=A9 Poussineau: > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/ppc_newworld.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/hw/ppc_newworld.c b/hw/ppc_newworld.c > index fabcc08..cd30f42 100644 > --- a/hw/ppc_newworld.c > +++ b/hw/ppc_newworld.c > @@ -274,6 +274,7 @@ static void ppc_core99_init(QEMUMachineInitArgs *ar= gs) > } > =20 > /* Register 8 MB of ISA IO space */ > + isa_bus_new(NULL, get_system_io()); > isa_mmio_init(0xf2000000, 0x00800000); > =20 > /* UniN init */ I understand that a bus will be necessary for the ISA I/O ports, but I do not like the bus added to the machine like this when at the same time we are trying to QOM'ify the chipsets for IDE. Where does this device logically sit? On UniNorth chipset? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg