From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuZWA-0007C6-A6 for qemu-devel@nongnu.org; Sun, 13 Jan 2013 21:11:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TuZW3-0007sf-Qh for qemu-devel@nongnu.org; Sun, 13 Jan 2013 21:11:18 -0500 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:54511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TuZW3-0007ro-7G for qemu-devel@nongnu.org; Sun, 13 Jan 2013 21:11:11 -0500 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 14 Jan 2013 07:40:02 +0530 Received: from d28relay04.in.ibm.com (d28relay04.in.ibm.com [9.184.220.61]) by d28dlp02.in.ibm.com (Postfix) with ESMTP id 2F070394004D for ; Mon, 14 Jan 2013 07:41:05 +0530 (IST) Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0E2B2eC4260262 for ; Mon, 14 Jan 2013 07:41:03 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0E2B3bI007531 for ; Mon, 14 Jan 2013 13:11:03 +1100 Message-ID: <50F368E9.5080201@linux.vnet.ibm.com> Date: Mon, 14 Jan 2013 10:09:45 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1357543689-11415-1-git-send-email-xiawenc@linux.vnet.ibm.com> <50EDF08E.7000402@redhat.com> <50EE5937.2040208@linux.vnet.ibm.com> <20130111115630.1f0bfdf1@doriath.home> In-Reply-To: <20130111115630.1f0bfdf1@doriath.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V2 00/10] snapshot: take block snapshots in unified way List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, aliguori@us.ibm.com, Pavel Hrdina , quintela@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com, dietmar@proxmox.com 于 2013-1-11 21:56, Luiz Capitulino 写道: > On Thu, 10 Jan 2013 14:01:27 +0800 > Wenchao Xia wrote: > >> 于 2013-1-10 6:34, Eric Blake 写道: >>> On 01/07/2013 12:27 AM, Wenchao Xia wrote: >>>> These patch added a seperated layer to take internal or external snapshots >>>> in a unified way, the granularity is block device, so other functions can >>>> just combine the request and submit, such as group snapshot, savevm. >>>> >>>> Total goal are: >>>> Live back up vm in external or internal image, which need three functions: >>>> 1 live snapshot block device internal/external. >>>> 2 live save vmstate internal/external. >>>> 3 combination of the function unit. >>>> >>>> This serial provide part one. >>>> >>> >>> The design on this series needs to be coordinated with Pavel's >>> attempts[1] to convert the existing HMP snapshot commands into QMP. I >>> don't want to spend too much time reviewing two different divergent >>> designs that both have the same goal of finally managing snapshots under >>> QMP. >>> >>> [1] https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg01326.html >>> >> A bit difference: This serial are taking internal/external block >> snapshots but Pavel's are focusing are vm whole internal snapshots. It > > Pavel's work makes savevm, loadvm and delvm available in QMP. Also note > that we do have blockdev-snapshot-sync. How does this series relate to it? > > I don't know if it's just me but, honestly speaking, I'm getting confused > about the various proposals and APIs for snapshots. > > IMHO, it's time to go back a bit from code and discuss the status of the > current APIs, what's missing and what the proposals are. > > This should also include writing a wiki page, as Anthony has done for > previous ideas (which worked quite well). > I agree, can you help create an account on qemu wiki for me? -- Best Regards Wenchao Xia