From: "Andreas Färber" <andreas.faerber@web.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-ppc@nongnu.org, sw@weilnetz.de,
"Hervé Poussineau" <hpoussin@reactos.org>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] pc87312: avoid define conflict on mingw32
Date: Mon, 14 Jan 2013 14:44:57 +0100 [thread overview]
Message-ID: <50F40BD9.3060509@web.de> (raw)
In-Reply-To: <50F282AC.7030003@reactos.org>
Am 13.01.2013 10:47, schrieb Hervé Poussineau:
> Blue Swirl a écrit :
>> Mingw32 headers define FAR, causing this warning:
>> /src/qemu/hw/pc87312.c:38:0: warning: "FAR" redefined [enabled by
>> default]
>> In file included from
>> /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windows.h:48:0,
>>
>> from /src/qemu/include/sysemu/os-win32.h:29,
>> from /src/qemu/include/qemu-common.h:46,
>> from /src/qemu/include/exec/ioport.h:27,
>> from /src/qemu/hw/isa.h:6,
>> from /src/qemu/hw/pc87312.h:28,
>> from /src/qemu/hw/pc87312.c:26:
>> /usr/local/lib/gcc/i686-mingw32msvc/4.7.0/../../../../i686-mingw32msvc/include/windef.h:34:0:
>> note: this is the location of the previous definition
>>
>> Avoid the warning by expanding the macros.
>>
>> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
>> ---
>> hw/pc87312.c | 38 +++++++++++++++++---------------------
>> 1 files changed, 17 insertions(+), 21 deletions(-)
>
> Acked-by: Hervé Poussineau <hpoussin@reactos.org>
Thanks, applied to prep-up:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up
Andreas
prev parent reply other threads:[~2013-01-14 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-13 8:12 [Qemu-devel] [PATCH] pc87312: avoid define conflict on mingw32 Blue Swirl
2013-01-13 9:47 ` Hervé Poussineau
2013-01-14 13:44 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F40BD9.3060509@web.de \
--to=andreas.faerber@web.de \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).