* [Qemu-devel] [PATCH] pc-testdev: use typedefs
@ 2013-01-08 9:31 Gerd Hoffmann
2013-01-08 15:51 ` Andreas Färber
0 siblings, 1 reply; 6+ messages in thread
From: Gerd Hoffmann @ 2013-01-08 9:31 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/pc-testdev.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/pc-testdev.c b/hw/pc-testdev.c
index 1928489..161284f 100644
--- a/hw/pc-testdev.c
+++ b/hw/pc-testdev.c
@@ -58,13 +58,13 @@ typedef struct PCTestdev {
#define TYPE_TESTDEV "pc-testdev"
#define TESTDEV(obj) \
- OBJECT_CHECK(struct PCTestdev, (obj), TYPE_TESTDEV)
+ OBJECT_CHECK(PCTestdev, (obj), TYPE_TESTDEV)
static void test_irq_line(void *opaque, hwaddr addr, uint64_t data,
unsigned len)
{
- struct PCTestdev *dev = opaque;
- struct ISADevice *isa = ISA_DEVICE(dev);
+ PCTestdev *dev = opaque;
+ ISADevice *isa = ISA_DEVICE(dev);
qemu_set_irq(isa_get_irq(isa, addr), !!data);
}
@@ -79,13 +79,13 @@ static const MemoryRegionOps test_irq_ops = {
static void test_ioport_write(void *opaque, hwaddr addr, uint64_t data,
unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
dev->ioport_data = data;
}
static uint64_t test_ioport_read(void *opaque, hwaddr addr, unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
return dev->ioport_data;
}
@@ -119,7 +119,7 @@ static const MemoryRegionOps test_flush_ops = {
static uint64_t test_iomem_read(void *opaque, hwaddr addr, unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
uint64_t ret = 0;
memcpy(&ret, &dev->iomem_buf[addr], len);
ret = le64_to_cpu(ret);
@@ -130,7 +130,7 @@ static uint64_t test_iomem_read(void *opaque, hwaddr addr, unsigned len)
static void test_iomem_write(void *opaque, hwaddr addr, uint64_t val,
unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
val = cpu_to_le64(val);
memcpy(&dev->iomem_buf[addr], &val, len);
dev->iomem_buf[addr] = val;
@@ -144,7 +144,7 @@ static const MemoryRegionOps test_iomem_ops = {
static int init_test_device(ISADevice *isa)
{
- struct PCTestdev *dev = TESTDEV(isa);
+ PCTestdev *dev = TESTDEV(isa);
MemoryRegion *mem = isa_address_space(isa);
MemoryRegion *io = isa_address_space_io(isa);
@@ -175,7 +175,7 @@ static void testdev_class_init(ObjectClass *klass, void *data)
static TypeInfo testdev_info = {
.name = TYPE_TESTDEV,
.parent = TYPE_ISA_DEVICE,
- .instance_size = sizeof(struct PCTestdev),
+ .instance_size = sizeof(PCTestdev),
.class_init = testdev_class_init,
};
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] pc-testdev: use typedefs
2013-01-08 9:31 [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
@ 2013-01-08 15:51 ` Andreas Färber
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2013-01-08 15:51 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
Am 08.01.2013 10:31, schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PULL] testdev cleanup
@ 2013-01-14 11:42 Gerd Hoffmann
2013-01-14 11:42 ` [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
2013-01-14 18:03 ` [Qemu-devel] [PULL] testdev cleanup Anthony Liguori
0 siblings, 2 replies; 6+ messages in thread
From: Gerd Hoffmann @ 2013-01-14 11:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Hi,
Small testdev cleanup.
please pull,
Gerd
The following changes since commit 63fb2590839162afdf14d7c0ee02d460766c0956:
Merge branch 'target-arm.next' of git://git.linaro.org/people/pmaydell/qemu-arm (2013-01-12 12:47:07 +0000)
are available in the git repository at:
git://git.kraxel.org/qemu testdev.2
for you to fetch changes up to 00e4d0dbad9f2d449f021394addec9dfae5678bf:
pc-testdev: use typedefs (2013-01-14 08:59:39 +0100)
----------------------------------------------------------------
Gerd Hoffmann (1):
pc-testdev: use typedefs
hw/pc-testdev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [PATCH] pc-testdev: use typedefs
2013-01-14 11:42 [Qemu-devel] [PULL] testdev cleanup Gerd Hoffmann
@ 2013-01-14 11:42 ` Gerd Hoffmann
2013-01-14 18:15 ` Andreas Färber
2013-01-14 18:03 ` [Qemu-devel] [PULL] testdev cleanup Anthony Liguori
1 sibling, 1 reply; 6+ messages in thread
From: Gerd Hoffmann @ 2013-01-14 11:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/pc-testdev.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/pc-testdev.c b/hw/pc-testdev.c
index ec0bc4b..cf64a1f 100644
--- a/hw/pc-testdev.c
+++ b/hw/pc-testdev.c
@@ -58,13 +58,13 @@ typedef struct PCTestdev {
#define TYPE_TESTDEV "pc-testdev"
#define TESTDEV(obj) \
- OBJECT_CHECK(struct PCTestdev, (obj), TYPE_TESTDEV)
+ OBJECT_CHECK(PCTestdev, (obj), TYPE_TESTDEV)
static void test_irq_line(void *opaque, hwaddr addr, uint64_t data,
unsigned len)
{
- struct PCTestdev *dev = opaque;
- struct ISADevice *isa = ISA_DEVICE(dev);
+ PCTestdev *dev = opaque;
+ ISADevice *isa = ISA_DEVICE(dev);
qemu_set_irq(isa_get_irq(isa, addr), !!data);
}
@@ -79,13 +79,13 @@ static const MemoryRegionOps test_irq_ops = {
static void test_ioport_write(void *opaque, hwaddr addr, uint64_t data,
unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
dev->ioport_data = data;
}
static uint64_t test_ioport_read(void *opaque, hwaddr addr, unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
return dev->ioport_data;
}
@@ -119,7 +119,7 @@ static const MemoryRegionOps test_flush_ops = {
static uint64_t test_iomem_read(void *opaque, hwaddr addr, unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
uint64_t ret = 0;
memcpy(&ret, &dev->iomem_buf[addr], len);
ret = le64_to_cpu(ret);
@@ -130,7 +130,7 @@ static uint64_t test_iomem_read(void *opaque, hwaddr addr, unsigned len)
static void test_iomem_write(void *opaque, hwaddr addr, uint64_t val,
unsigned len)
{
- struct PCTestdev *dev = opaque;
+ PCTestdev *dev = opaque;
val = cpu_to_le64(val);
memcpy(&dev->iomem_buf[addr], &val, len);
dev->iomem_buf[addr] = val;
@@ -144,7 +144,7 @@ static const MemoryRegionOps test_iomem_ops = {
static int init_test_device(ISADevice *isa)
{
- struct PCTestdev *dev = TESTDEV(isa);
+ PCTestdev *dev = TESTDEV(isa);
MemoryRegion *mem = isa_address_space(isa);
MemoryRegion *io = isa_address_space_io(isa);
@@ -175,7 +175,7 @@ static void testdev_class_init(ObjectClass *klass, void *data)
static const TypeInfo testdev_info = {
.name = TYPE_TESTDEV,
.parent = TYPE_ISA_DEVICE,
- .instance_size = sizeof(struct PCTestdev),
+ .instance_size = sizeof(PCTestdev),
.class_init = testdev_class_init,
};
--
1.7.9.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PULL] testdev cleanup
2013-01-14 11:42 [Qemu-devel] [PULL] testdev cleanup Gerd Hoffmann
2013-01-14 11:42 ` [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
@ 2013-01-14 18:03 ` Anthony Liguori
1 sibling, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2013-01-14 18:03 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
Pulled, thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] pc-testdev: use typedefs
2013-01-14 11:42 ` [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
@ 2013-01-14 18:15 ` Andreas Färber
0 siblings, 0 replies; 6+ messages in thread
From: Andreas Färber @ 2013-01-14 18:15 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
Am 14.01.2013 12:42, schrieb Gerd Hoffmann:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Again lacking my Reviewed-by... :( I simply use `git rebase -i ...` or
`git commit --amend` to edit these things in.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-01-14 18:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-14 11:42 [Qemu-devel] [PULL] testdev cleanup Gerd Hoffmann
2013-01-14 11:42 ` [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
2013-01-14 18:15 ` Andreas Färber
2013-01-14 18:03 ` [Qemu-devel] [PULL] testdev cleanup Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 9:31 [Qemu-devel] [PATCH] pc-testdev: use typedefs Gerd Hoffmann
2013-01-08 15:51 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).