qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, stuart.yoder@freescale.com
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: E500: Put dtb after initrd
Date: Mon, 14 Jan 2013 20:33:50 +0100	[thread overview]
Message-ID: <50F45D9E.1020302@suse.de> (raw)
In-Reply-To: <1358191607-6837-1-git-send-email-agraf@suse.de>

On 01/14/2013 08:26 PM, Alexander Graf wrote:
> We have 3 blobs we need to load when booting the system:
>
>    - kernel
>    - initrd
>    - dtb
>
> We place them in physical memory in that order. At least we should.
> This patch fixes the dtb location up to take the initrd location into
> account, fixing its offset.
>
> Reported-by: Stuart Yoder<stuart.yoder@freescale.com>
> Signed-off-by: Alexander Graf<agraf@suse.de>

Ignore this one :).


Alex

> ---
>   hw/ppc/e500.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index 3a9e1c7..516d219 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -460,7 +460,7 @@ void ppce500_init(PPCE500Params *params)
>       target_long kernel_size=0;
>       target_ulong dt_base = 0;
>       target_ulong initrd_base = 0;
> -    target_long initrd_size=0;
> +    target_long initrd_size = 0;
>       int i = 0, j, k;
>       unsigned int pci_irq_nrs[4] = {1, 2, 3, 4};
>       qemu_irq **irqs, *mpic;
> @@ -642,7 +642,8 @@ void ppce500_init(PPCE500Params *params)
>           struct boot_info *boot_info;
>           int dt_size;
>
> -        dt_base = (loadaddr + kernel_size + DTC_LOAD_PAD)&  ~DTC_PAD_MASK;
> +        dt_base = (loadaddr + kernel_size + initrd_size + DTC_LOAD_PAD)&
> +                  ~DTC_PAD_MASK;
>           dt_size = ppce500_load_device_tree(env, params, dt_base, initrd_base,
>                                              initrd_size);
>           if (dt_size<  0) {

      reply	other threads:[~2013-01-14 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-14 19:26 [Qemu-devel] [PATCH] PPC: E500: Put dtb after initrd Alexander Graf
2013-01-14 19:33 ` Alexander Graf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50F45D9E.1020302@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=stuart.yoder@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).