From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TurkD-0007yq-U9 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:39:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TurkC-0007C2-JX for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:39:01 -0500 Received: from qmta07.emeryville.ca.mail.comcast.net ([76.96.30.64]:49845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TurkC-0007Bx-B9 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:39:00 -0500 Message-ID: <50F47A5C.2040400@redhat.com> Date: Mon, 14 Jan 2013 14:36:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <50F04D1D.1080406@redhat.com> <1358163305-6730-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1358163305-6730-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2ROIWCDMQXDWXNVLCONWB" Subject: Re: [Qemu-devel] [PATCH v4 9/10] chardev: add socket chardev support to chardev-add (qmp) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2ROIWCDMQXDWXNVLCONWB Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/14/2013 04:35 AM, Gerd Hoffmann wrote: > qemu_chr_open_socket is split into two functions. All initialization > after creating the socket file handler is split away into the new > qemu_chr_open_socket_fd function. >=20 > chr->filename doesn't get filled from QemuOpts any more. Qemu gathers > the information using getsockname and getnameinfo instead. This way it= > will also work correctly for file handles passed via file descriptor > passing. >=20 > Finally qmp_chardev_open_socket() is the actual qmp hotplug > implementation which basically just calls socket_listen or > socket_connect and the new qemu_chr_open_socket_fd function. >=20 > Signed-off-by: Gerd Hoffmann > --- > qapi-schema.json | 28 ++++++++- > qemu-char.c | 166 ++++++++++++++++++++++++++++++++++++----------= ------- > 2 files changed, 138 insertions(+), 56 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2ROIWCDMQXDWXNVLCONWB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9HpcAAoJEKeha0olJ0NqlRoH/398oKRWWlDbaifuM8H0s2IH imqeoLLSWH8n5Vgxegd99sHNdR21O25cOv9csgdaWBVQiiNiNXRfV7QlMwr8+3Yx GXIL7aYobLBy+DmSey3OwIJvdD3wr80RUbi9o8INSfGsiDkne9sL1u0U3Ow3Cptp 22FSsrVfix47WV9+bixXArnvCAozy9ssfaUmpS+kXTjIU4xAbRmnP4oxrqobJV/6 kDdyIWFXYRgSiTUiRLWawu4vxAcrMHKVimkfxjQqH/5Vx1MINDq1BqwNIfT1PVIY YZ0dkWzutUUhCj5XN1R/J5onnJySXhWZzYc33wy0xXhny8g7hpnSQYHAopLTWqM= =CSTS -----END PGP SIGNATURE----- ------enig2ROIWCDMQXDWXNVLCONWB--