From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TurlA-0000W9-As
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:40:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Turl8-0007ZL-U6
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:40:00 -0500
Received: from cantor2.suse.de ([195.135.220.15]:48042 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Turl8-0007Yg-Nl
	for qemu-devel@nongnu.org; Mon, 14 Jan 2013 16:39:58 -0500
Message-ID: <50F47B25.8020203@suse.de>
Date: Mon, 14 Jan 2013 22:39:49 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1357747019-20580-1-git-send-email-fred.konrad@greensocs.com>
	<1357747019-20580-5-git-send-email-fred.konrad@greensocs.com>
	<87bocrwpjr.fsf@codemonkey.ws> <50F46C44.9080406@greensocs.com>
In-Reply-To: <50F46C44.9080406@greensocs.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 4/7] virtio-pci-bus: introduce
	virtio-pci-bus.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?KONRAD_Fr=E9d=E9ric?= <fred.konrad@greensocs.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, Anthony Liguori <aliguori@us.ibm.com>, e.voevodin@samsung.com, mst@redhat.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, aneesh.kumar@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com

Am 14.01.2013 21:36, schrieb KONRAD Fr=E9d=E9ric:
> On 14/01/2013 20:08, Anthony Liguori wrote:
>> fred.konrad@greensocs.com writes:
>>
>>> +VirtioBusState *virtio_pci_bus_new(VirtIOPCIProxy *dev)
>>> +{
>>> +    DeviceState *qdev =3D DEVICE(dev);
>>> +    BusState *qbus =3D qbus_create(TYPE_VIRTIO_PCI_BUS, qdev, NULL);
>>> +    VirtioBusState *bus =3D VIRTIO_BUS(qbus);
>>> +    qbus->allow_hotplug =3D 0;
>> Any reason to not use a qbus_create_inplace()?
>>
>> Regards,
>>
>> Anthony Liguori
> If I change the bus field of VirtIOPCIProxy from VirtioBus* to VirtioBu=
s
> and I use qbus_create_inplace
> I can't use qbus_create_inplace(BUS(&dev->bus),...) as the object is no=
t
> initialised yet right?

Correct, you need to use qbus_create_inplace((BusState *)&dev->bus,...).
I ran into the same trap for ADB last night. ;)

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg