From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TutOC-0006SO-7k for qemu-devel@nongnu.org; Mon, 14 Jan 2013 18:24:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TutOA-00019n-Se for qemu-devel@nongnu.org; Mon, 14 Jan 2013 18:24:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TutOA-00019c-J8 for qemu-devel@nongnu.org; Mon, 14 Jan 2013 18:24:22 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0ENOLe8019108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Jan 2013 18:24:22 -0500 Message-ID: <50F493A5.6080507@redhat.com> Date: Mon, 14 Jan 2013 16:24:21 -0700 From: Eric Blake MIME-Version: 1.0 References: <1355751593-31535-1-git-send-email-mrezanin@redhat.com> <107b8c42c613daa5b64e0f4d0281d12e92ebd61d.1358148502.git.mrezanin@redhat.com> In-Reply-To: <107b8c42c613daa5b64e0f4d0281d12e92ebd61d.1358148502.git.mrezanin@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2KFRCDHWNLJGQKBKCBAUT" Subject: Re: [Qemu-devel] [PATCH v8 4/4] Add qemu-img compare documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Miroslav Rezanina Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2KFRCDHWNLJGQKBKCBAUT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/14/2013 03:26 AM, Miroslav Rezanina wrote: > Adding documentation for new qemu-img subcommand compare. >=20 > Signed-off-by: Miroslav Rezanina > --- > qemu-img.c | 7 ++++++- > qemu-img.texi | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+), 1 deletions(-) Your series is lacking a test case; it would be useful to test both identical images, images that are identical only when not in strict mode, and differing images. > +Check if two images have the same content. You can compare images with= > +different format or settings. > + > +The format is probed unless you specify it by @var{-f} (used for @var{= filename1}) and/or @var{-F} (used for @var{filename2}) option. Long line; worth wrapping. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2KFRCDHWNLJGQKBKCBAUT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9JOlAAoJEKeha0olJ0Nq8kUH/iCQ5B0LiescBlzwddpva/QB K6swvLda9wv23FEJxsUQJOmSs4ARZG8PZMB3PXekYmYR8lcWxxjQl7WQSheVxwRX kdiNUbxZAUSFk+YF9AsDgr4vqhFaQmu0fqtipTCJjry4/KUfL8sit50xIlNvQt1x HvyVPTTPt1kEAyv/wCTuryPcFFYFH+kn4V/ifCVNyrwVhj5bgIprynfyk28fTkQA /qxN9iQQemKJnOFRriVU6ZJuOn6RM1T5UNeKf/7PAhrNq/ixyXgMp31vLeWLNDww fsGGOkHR1MQ9EU9Q5XzfqnQzi+pjqCmiR0Dgthc6iSiWyQBMb3pLCvFWTWmS0kA= =kiRU -----END PGP SIGNATURE----- ------enig2KFRCDHWNLJGQKBKCBAUT--