From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58328) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv0yj-0000OR-Lg for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:30:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv0yi-0000pq-I7 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:30:37 -0500 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:60338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv0yh-0000pT-V9 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 02:30:36 -0500 Received: from /spool/local by e28smtp03.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 15 Jan 2013 12:59:12 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id 79215E0050 for ; Tue, 15 Jan 2013 13:00:50 +0530 (IST) Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r0F7UT1o44564516 for ; Tue, 15 Jan 2013 13:00:29 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r0F7USZa012350 for ; Tue, 15 Jan 2013 18:30:29 +1100 Message-ID: <50F50592.8090305@linux.vnet.ibm.com> Date: Tue, 15 Jan 2013 15:30:26 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1358147387-8221-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1358147387-8221-3-git-send-email-xiawenc@linux.vnet.ibm.com> <20130114150829.01875c0c@doriath.home> In-Reply-To: <20130114150829.01875c0c@doriath.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V3 02/11] block: add bdrv_get_filename() function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, phrdina@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, armbru@redhat.com, pbonzini@redhat.com 于 2013-1-15 1:08, Luiz Capitulino 写道: > On Mon, 14 Jan 2013 15:09:38 +0800 > Wenchao Xia wrote: > >> This function will simply return the uri or filename used >> to open the image. >> >> Reviewed-by: Eric Blake >> Signed-off-by: Wenchao Xia >> --- >> block.c | 5 +++++ >> include/block/block.h | 1 + >> 2 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/block.c b/block.c >> index 4e28c55..5f95da5 100644 >> --- a/block.c >> +++ b/block.c >> @@ -2967,6 +2967,11 @@ BlockStatsList *qmp_query_blockstats(Error **errp) >> return head; >> } >> >> +const char *bdrv_get_filename(BlockDriverState *bs) >> +{ > > bs can be const. > OK. -- Best Regards Wenchao Xia