From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv2ew-0005r2-Nx for qemu-devel@nongnu.org; Tue, 15 Jan 2013 04:18:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv2eu-0006Qo-Fv for qemu-devel@nongnu.org; Tue, 15 Jan 2013 04:18:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40373 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv2eu-0006QX-6c for qemu-devel@nongnu.org; Tue, 15 Jan 2013 04:18:16 -0500 Message-ID: <50F51ED2.8000406@suse.de> Date: Tue, 15 Jan 2013 10:18:10 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1358238598-31451-1-git-send-email-afaerber@suse.de> <1358239775.14624.35.camel@liguang.fnst.cn.fujitsu.com> In-Reply-To: <1358239775.14624.35.camel@liguang.fnst.cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu v6 0/4] target-i386: Clean up DR7 breakpoint handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: li guang Cc: Peter Maydell , Igor Mammedov , Jan Kiszka , qemu-devel@nongnu.org, Eduardo Habkost Am 15.01.2013 09:49, schrieb li guang: > Thanks for your smooth work! >=20 > fine for me. Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas > =E5=9C=A8 2013-01-15=E4=BA=8C=E7=9A=84 09:29 +0100=EF=BC=8CAndreas F=C3= =A4rber=E5=86=99=E9=81=93=EF=BC=9A >> Hello Guang, >> >> Are you okay with this version? >> >> Regards, >> Andreas >> >> v5 -> v6: >> * Fix bisectability by deferring use of hw_{local,global}_breakpoint_e= nabled(). >> * Reword the commit messages for clarity. >> * Squash more constant usage into first patch. >> * Reorder DATA_RW and DATA_WR to match original switch cases. >> * Untangle introduction of breakpoint helper functions from goto/if re= factorings. >> * Make hw_breakpoint_enabled() return bool. >> * Keep IO_RW in place for patch readability. >> * Keep reg variable name for patch readability. >> * Move {bp,wp}_match inside loop to clarify scope and to avoid double = false init. >> * Make check_hw_breakpoints() return bool, change force_dr6_update arg= to bool. >> >> changes v4->v5: >> >> - fix some not well formated changes. >> - split functional and non-functional changes for cherry-picking >> suggested by Andreas F=C3=A4rber >> >> changes v3->v4: >> >> - fix wrong logic of hw_{global,local}_breakpoint_enabled usage >> suggested by Peter Maydell >> >> changes v2->v3: >> >> - split hw_breakpoint_enabled into hw_{global,local}_breakpoint_enable= d >> >> changes v1->v2: >> >> - add _TYPE_ to the name of dr7 bit field >> - fix some coding styles >> suggested by Peter Maydell >> >> Cc: liguang >> Cc: Eduardo Habkost >> Cc: Igor Mammedov >> Cc: Jan Kiszka >> Cc: Peter Maydell >> >> liguang (4): >> target-i386: Define DR7 bit field constants >> target-i386: Introduce hw_{local,global}_breakpoint_enabled() >> target-i386: Avoid goto in hw_breakpoint_insert() >> target-i386: Use switch in check_hw_breakpoints() >> >> target-i386/cpu.h | 23 ++++++++++-- >> target-i386/helper.c | 87 +++++++++++++++++++++++++++++-------= --------- >> target-i386/machine.c | 5 +-- >> target-i386/misc_helper.c | 6 ++-- >> target-i386/seg_helper.c | 9 ++--- >> 5 Dateien ge=C3=A4ndert, 88 Zeilen hinzugef=C3=BCgt(+), 42 Zeilen ent= fernt(-) >> >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg