From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer
Date: Tue, 15 Jan 2013 14:49:53 +0100 [thread overview]
Message-ID: <50F55E81.5020405@redhat.com> (raw)
In-Reply-To: <1358256220-5460-4-git-send-email-armbru@redhat.com>
Am 15.01.2013 14:23, schrieb Markus Armbruster:
> win32_aio_submit() allocates it with qemu_blockalign(), therefore it
> must be freed with qemu_vfree(), not g_free().
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> block/win32-aio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/win32-aio.c b/block/win32-aio.c
> index 46a5db7..0383370 100644
> --- a/block/win32-aio.c
> +++ b/block/win32-aio.c
> @@ -87,7 +87,7 @@ static void win32_aio_process_completion(QEMUWin32AIOState *s,
> memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len);
> p += qiov->iov[i].iov_len;
> }
> - g_free(waiocb->buf);
> + qemu_vfree(waiocb->buf);
> }
> }
Independent bug: waiocb->buf is leaked for writes and failed reads.
Kevin
next prev parent reply other threads:[~2013-01-15 13:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 13:23 [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree() Markus Armbruster
2013-01-15 13:23 ` [Qemu-devel] [PATCH 1/4] w32: Make qemu_vfree() accept NULL like the POSIX implementation Markus Armbruster
2013-01-15 13:23 ` [Qemu-devel] [PATCH 2/4] scsi-disk: qemu_vfree(NULL) is fine, simplify Markus Armbruster
2013-01-15 15:17 ` Paolo Bonzini
2013-01-15 13:23 ` [Qemu-devel] [PATCH 3/4] win32-aio: Fix how win32_aio_process_completion() frees buffer Markus Armbruster
2013-01-15 13:49 ` Kevin Wolf [this message]
2013-01-15 13:23 ` [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer Markus Armbruster
2013-01-15 13:52 ` Kevin Wolf
2013-01-15 14:20 ` Markus Armbruster
2013-01-15 15:20 ` Paolo Bonzini
2013-01-15 13:52 ` [Qemu-devel] [PATCH 0/4] Fixes around qemu_vfree() Kevin Wolf
2013-01-15 15:50 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F55E81.5020405@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).