From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39611)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tv6tp-00075i-OE
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:49:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tv6to-0003Ex-Ey
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:49:57 -0500
Received: from mx1.redhat.com ([209.132.183.28]:26790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Tv6to-0003Ep-7l
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 08:49:56 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0FDnttR010556
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 15 Jan 2013 08:49:55 -0500
Message-ID: <50F55E81.5020405@redhat.com>
Date: Tue, 15 Jan 2013 14:49:53 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1358256220-5460-1-git-send-email-armbru@redhat.com>
	<1358256220-5460-4-git-send-email-armbru@redhat.com>
In-Reply-To: <1358256220-5460-4-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] win32-aio: Fix how
 win32_aio_process_completion() frees buffer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

Am 15.01.2013 14:23, schrieb Markus Armbruster:
> win32_aio_submit() allocates it with qemu_blockalign(), therefore it
> must be freed with qemu_vfree(), not g_free().
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  block/win32-aio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/win32-aio.c b/block/win32-aio.c
> index 46a5db7..0383370 100644
> --- a/block/win32-aio.c
> +++ b/block/win32-aio.c
> @@ -87,7 +87,7 @@ static void win32_aio_process_completion(QEMUWin32AIOState *s,
>                  memcpy(p, qiov->iov[i].iov_base, qiov->iov[i].iov_len);
>                  p += qiov->iov[i].iov_len;
>              }
> -            g_free(waiocb->buf);
> +            qemu_vfree(waiocb->buf);
>          }
>      }

Independent bug: waiocb->buf is leaked for writes and failed reads.

Kevin