From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv8Jm-0004nt-N3 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:20:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tv8Jl-0004vH-Do for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:20:50 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:60181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tv8Jl-0004um-11 for qemu-devel@nongnu.org; Tue, 15 Jan 2013 10:20:49 -0500 Received: by mail-wg0-f48.google.com with SMTP id 16so143269wgi.3 for ; Tue, 15 Jan 2013 07:20:47 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50F573CC.9050309@redhat.com> Date: Tue, 15 Jan 2013 16:20:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358256220-5460-1-git-send-email-armbru@redhat.com> <1358256220-5460-5-git-send-email-armbru@redhat.com> <50F55F06.60402@redhat.com> <87d2x6cyuk.fsf@blackfin.pond.sub.org> In-Reply-To: <87d2x6cyuk.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] block: Fix how mirror_run() frees its buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin Wolf , qemu-devel@nongnu.org, stefanha@redhat.com Il 15/01/2013 15:20, Markus Armbruster ha scritto: >> > Am 15.01.2013 14:23, schrieb Markus Armbruster: >>> >> It allocates with qemu_blockalign(), therefore it must free with >>> >> qemu_vfree(), not g_free(). >>> >> >>> >> Since I'm touching it anyway, move the free to a more obviosly correct >>> >> place. >> > >> > ...except that it's now leaked for all error cases but the first. > Brain fart caused by looking at the RHEL code, will respin. > > I'll pick this in my own mirror series, if you don't mind. Paolo