From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvAUt-0007sQ-US for qemu-devel@nongnu.org; Tue, 15 Jan 2013 12:40:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvAUs-00056w-Kj for qemu-devel@nongnu.org; Tue, 15 Jan 2013 12:40:27 -0500 Message-ID: <50F59485.5000100@suse.de> Date: Tue, 15 Jan 2013 18:40:21 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20130113104728.GA23188@redhat.com> <50F52AD2.6080400@suse.de> <20130115163237.GA7997@redhat.com> In-Reply-To: <20130115163237.GA7997@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL] pci,virtio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-stable@nongnu.org, Alexander Graf , qemu-devel@nongnu.org, alex.williamson@redhat.com, Anthony Liguori , pbonzini@redhat.com, Daniel Gollub Am 15.01.2013 17:32, schrieb Michael S. Tsirkin: > On Tue, Jan 15, 2013 at 11:09:22AM +0100, Andreas F=E4rber wrote: >> Am 13.01.2013 11:47, schrieb Michael S. Tsirkin: >>> virtio-pci: cache msix messages >> >> This broke the build with PowerKVM: >> >> LINK ppc64-softmmu/qemu-system-ppc64 >> ../hw/virtio-pci.o: In function `kvm_virtio_pci_vq_vector_unmask': >> /home/andreas/QEMU/qemu/hw/virtio-pci.c:622: undefined reference to >> `kvm_irqchip_update_msi_route' >> collect2: error: ld returned 1 exit status >> make[1]: *** [qemu-system-ppc64] Fehler 1 >> make: *** [subdir-ppc64-softmmu] Fehler 2 >> >> Can you supply a fix? It's not obvious to me how. >=20 > I'm not sure how to build this. Can you tell me pls? Ideally Daniel would set up your pci branch to build on the revived ppc buildbot (and on s390, thinking of virtio). When on a Linux/ppc host the KVM headers are detected, nothing special needs to be configured to build that code. Cross-compilation should work as well but obviously needs the right environment; same for a ppc chroot with linux-user+binfmt. > Maybe the below helps? >=20 > kvm: add stub for kvm_irqchip_update_msi_route >=20 > Signed-off-by: Michael S. Tsirkin Tested-by: Andreas F=E4rber Great, together with Blue's bswap patch this fixes the build for me. Thanks for the quick response! Regards, Andreas > diff --git a/kvm-all.c b/kvm-all.c > index fc0c6e7..bac67da 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -1182,6 +1182,11 @@ static int kvm_irqchip_assign_irqfd(KVMState *s,= int fd, int virq, bool assign) > { > abort(); > } > + > +int kvm_irqchip_update_msi_route(KVMState *s, int virq, MSIMessage msg= ) > +{ > + return -ENOSYS; > +} > #endif /* !KVM_CAP_IRQ_ROUTING */ > =20 > int kvm_irqchip_add_irqfd_notifier(KVMState *s, EventNotifier *n, int = virq) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg