From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvG1d-0002mR-Gz for qemu-devel@nongnu.org; Tue, 15 Jan 2013 18:34:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvG1a-0002aO-NA for qemu-devel@nongnu.org; Tue, 15 Jan 2013 18:34:37 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:64176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvG1a-0002aE-FQ for qemu-devel@nongnu.org; Tue, 15 Jan 2013 18:34:34 -0500 Received: by mail-wi0-f175.google.com with SMTP id hm11so2900076wib.14 for ; Tue, 15 Jan 2013 15:34:33 -0800 (PST) Message-ID: <50F5E785.6060304@gmail.com> Date: Wed, 16 Jan 2013 03:34:29 +0400 From: Vadim Evard MIME-Version: 1.0 References: <1358270033-18064-1-git-send-email-stefanha@redhat.com> <1358270033-18064-4-git-send-email-stefanha@redhat.com> <87obgqnjg1.fsf@codemonkey.ws> In-Reply-To: <87obgqnjg1.fsf@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3 v2] configure: try pkg-config for curses List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance. Fixes #1094786 for me. Signed-off-by: Vadim Evard Signed-off-by: Stefan Hajnoczi --- configure | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/configure b/configure index c908f66..477c4e0 100755 --- a/configure +++ b/configure @@ -2039,7 +2039,7 @@ fi if test "$mingw32" = "yes" ; then curses_list="-lpdcurses" else - curses_list="-lncurses -lcurses" + curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses 2>/dev/null)" fi if test "$curses" != "no" ; then @@ -2052,13 +2052,16 @@ int main(void) { return s != 0; } EOF + IFS=: for curses_lib in $curses_list; do + unset IFS if compile_prog "" "$curses_lib" ; then curses_found=yes libs_softmmu="$curses_lib $libs_softmmu" break fi done + unset IFS if test "$curses_found" = "yes" ; then curses=yes else -- 1.7.10.4 On 16.01.2013 02:57, Anthony Liguori wrote: > Stefan Hajnoczi writes: > >> From: Vadim Evard >> >> Static linkikng against ncurses may require explicit -ltinfo. >> In case -lcurses and -lncurses both didn't work give pkg-config a >> chance. >> >> Fixes #1094786 for me. >> >> Signed-off-by: Vadim Evard >> Signed-off-by: Stefan Hajnoczi >> --- >> configure | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index c908f66..40473a9 100755 >> --- a/configure >> +++ b/configure >> @@ -2039,7 +2039,7 @@ fi >> if test "$mingw32" = "yes" ; then >> curses_list="-lpdcurses" >> else >> - curses_list="-lncurses -lcurses" >> + curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)" > > Please fix this as a follow up but this is sloppy. > > pkg-config spews stuff to stderr when a package isn't found so this ends > up outputting junk in the configure if ncurses isn't found. > > Regards, > > Anthony Liguori > >> fi >> >> if test "$curses" != "no" ; then >> @@ -2052,13 +2052,16 @@ int main(void) { >> return s != 0; >> } >> EOF >> + IFS=: >> for curses_lib in $curses_list; do >> + unset IFS >> if compile_prog "" "$curses_lib" ; then >> curses_found=yes >> libs_softmmu="$curses_lib $libs_softmmu" >> break >> fi >> done >> + unset IFS >> if test "$curses_found" = "yes" ; then >> curses=yes >> else >> -- >> 1.8.0.2 >