From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TvKBp-0007H4-3r
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 23:01:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TvKBo-0005vS-19
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 23:01:25 -0500
Received: from cantor2.suse.de ([195.135.220.15]:57245 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TvKBn-0005vN-Ns
	for qemu-devel@nongnu.org; Tue, 15 Jan 2013 23:01:23 -0500
Message-ID: <50F6260F.8050601@suse.de>
Date: Wed, 16 Jan 2013 05:01:19 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1358308620-14122-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1358308620-14122-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Drop
	OpenRISCCPUList
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Liu <proljc@gmail.com>
Cc: qemu-devel@nongnu.org

Am 16.01.2013 04:57, schrieb Andreas F=C3=A4rber:
> It was missed in the previous cleanup because its naming did not match
> the *CPUListState pattern. Use the generalized CPUListState instead.
>=20
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>

Jia, please add a MAINTAINERS entry for target-openrisc/ so that you
automatically get cc'ed on patches.

Thanks,
Andreas

> ---
>  target-openrisc/cpu.c |    9 ++-------
>  1 Datei ge=C3=A4ndert, 2 Zeilen hinzugef=C3=BCgt(+), 7 Zeilen entfernt=
(-)
>=20
> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c
> index 56544d8..7a55112 100644
> --- a/target-openrisc/cpu.c
> +++ b/target-openrisc/cpu.c
> @@ -170,11 +170,6 @@ OpenRISCCPU *cpu_openrisc_init(const char *cpu_mod=
el)
>      return cpu;
>  }
> =20
> -typedef struct OpenRISCCPUList {
> -    fprintf_function cpu_fprintf;
> -    FILE *file;
> -} OpenRISCCPUList;
> -
>  /* Sort alphabetically by type name, except for "any". */
>  static gint openrisc_cpu_list_compare(gconstpointer a, gconstpointer b=
)
>  {
> @@ -196,7 +191,7 @@ static gint openrisc_cpu_list_compare(gconstpointer=
 a, gconstpointer b)
>  static void openrisc_cpu_list_entry(gpointer data, gpointer user_data)
>  {
>      ObjectClass *oc =3D data;
> -    OpenRISCCPUList *s =3D user_data;
> +    CPUListState *s =3D user_data;
> =20
>      (*s->cpu_fprintf)(s->file, "  %s\n",
>                        object_class_get_name(oc));
> @@ -204,7 +199,7 @@ static void openrisc_cpu_list_entry(gpointer data, =
gpointer user_data)
> =20
>  void cpu_openrisc_list(FILE *f, fprintf_function cpu_fprintf)
>  {
> -    OpenRISCCPUList s =3D {
> +    CPUListState s =3D {
>          .file =3D f,
>          .cpu_fprintf =3D cpu_fprintf,
>      };

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg