From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvPPb-00021y-26 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:36:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvPPX-00082L-V9 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:35:58 -0500 Received: from goliath.siemens.de ([192.35.17.28]:26306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvPPX-00082G-LK for qemu-devel@nongnu.org; Wed, 16 Jan 2013 04:35:55 -0500 Message-ID: <50F67479.8050909@siemens.com> Date: Wed, 16 Jan 2013 10:35:53 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <50C851EA.9040903@siemens.com> <50D07D1A.1080204@suse.de> In-Reply-To: <50D07D1A.1080204@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/2] i2c: Add AT24Cxx EEPROM model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Stefan Weil , qemu-devel , Stefan Hajnoczi On 2012-12-18 15:26, Andreas F=E4rber wrote: > Am 12.12.2012 10:44, schrieb Jan Kiszka: >> On 2012-11-19 15:24, Jan Kiszka wrote: >>> See patches for details. >>> >>> Jan Kiszka (2): >>> i2c: Introduce device address mask >>> Add AT24Cxx I2C EEPROM device model >>> >>> hw/Makefile.objs | 2 +- >>> hw/at24.c | 363 ++++++++++++++++++++++++++++++++++++++++++++= ++++++++++ >>> hw/ds1338.c | 2 +- >>> hw/i2c.c | 9 +- >>> hw/i2c.h | 3 +- >>> hw/lm832x.c | 2 +- >>> hw/max7310.c | 2 +- >>> hw/pxa2xx.c | 3 +- >>> hw/smbus.c | 2 +- >>> hw/ssd0303.c | 2 +- >>> hw/tmp105.c | 2 +- >>> hw/tosa.c | 2 +- >>> hw/twl92230.c | 2 +- >>> hw/wm8750.c | 2 +- >>> hw/z2.c | 2 +- >>> 15 files changed, 383 insertions(+), 17 deletions(-) >>> create mode 100644 hw/at24.c >>> >> >> Ping. Both still apply over latest master, and addressable review >> comments are not pending according to my understanding. >=20 > Hello Jan, did you see my recent proposal of an I2C qtest framework? :) > For one I'd be interested in feedback from someone who knows I2C and fo= r > another maybe you could follow-up your patch with some test case (I2C > master shouldn't matter, I guess). I haven't seen your test framework yet, and I'm unfortunately lacking time to work on test cases ATM. We were simply testing this device against the Linux driver. Wasn't there also some test environment that builds on top of a guest OS? Jan --=20 Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux