From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvQGy-0002lq-RZ for qemu-devel@nongnu.org; Wed, 16 Jan 2013 05:31:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvQGx-0005M2-Lx for qemu-devel@nongnu.org; Wed, 16 Jan 2013 05:31:08 -0500 Message-ID: <50F68166.3020803@suse.de> Date: Wed, 16 Jan 2013 11:31:02 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1357828825-2414-1-git-send-email-pbonzini@redhat.com> <50F63A2D.1010005@suse.de> <50F67C7D.3010103@redhat.com> In-Reply-To: <50F67C7D.3010103@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] virtio-s390: add a reset function to virtio-s390 devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, agraf@suse.de, =?ISO-8859-15?Q?KONRAD_Fr=E9d=E9?= =?ISO-8859-15?Q?ric?= , Michael Roth , qemu-stable@nongnu.org Am 16.01.2013 11:10, schrieb Paolo Bonzini: > Il 16/01/2013 06:27, Andreas F=E4rber ha scritto: >> Am 10.01.2013 15:40, schrieb Paolo Bonzini: >>> virtio-s390 devices are not being reset when their bus is. To fix >>> this, add a reset method that forwards to virtio_reset. This is >>> only needed because of the "strange" modeling of virtio devices; >>> the ->vdev link is being handled manually rather than through qdev. >>> >>> Signed-off-by: Paolo Bonzini >>> --- >>> hw/s390-virtio-bus.c | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/hw/s390-virtio-bus.c b/hw/s390-virtio-bus.c >>> index 7e99175..1e3e4f0 100644 >>> --- a/hw/s390-virtio-bus.c >>> +++ b/hw/s390-virtio-bus.c >>> @@ -505,6 +505,13 @@ static int s390_virtio_busdev_init(DeviceState *= dev) >>> return _info->init(_dev); >>> } >>> =20 >>> +static void s390_virtio_busdev_reset(DeviceState *dev) >>> +{ >>> + VirtIOS390Device *_dev =3D (VirtIOS390Device *)dev; >> >> Underscore alert. ;) What about naming the arg d and the variable dev? >=20 > True, but the file uses this convention throughout. Then I'm beginning to understand why Fred's patchset is so large... Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg