From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
Yan Vugenfirer <yan@daynix.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org, Gerhard Wiesinger <lists@wiesinger.com>
Subject: Re: [Qemu-devel] [PATCH v9 4/5] Adding packet abstraction for VMWARE network devices
Date: Wed, 16 Jan 2013 16:33:48 +0100 [thread overview]
Message-ID: <50F6C85C.5020109@redhat.com> (raw)
In-Reply-To: <20130116144800.GB9679@stefanha-thinkpad.redhat.com>
Il 16/01/2013 15:48, Stefan Hajnoczi ha scritto:
>> > hw/vmxnet_rx_pkt.c | 187 ++++++++++++++++++
>> > hw/vmxnet_rx_pkt.h | 173 ++++++++++++++++
>> > hw/vmxnet_tx_pkt.c | 567 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>> > hw/vmxnet_tx_pkt.h | 148 ++++++++++++++
>> > 4 files changed, 1075 insertions(+)
>> > create mode 100644 hw/vmxnet_rx_pkt.c
>> > create mode 100644 hw/vmxnet_rx_pkt.h
>> > create mode 100644 hw/vmxnet_tx_pkt.c
>> > create mode 100644 hw/vmxnet_tx_pkt.h
> There are other VMware-specific hw/ files. Please create hw/vmware/ and
> put source files in there without the prefix. Check hw/pci/ or other
> subdirectories for how to setup Makefile.objs, it's pretty simple.
I don't think we have enough plans for hw/ structure to create
directories yet. What we have so far is basically hw/<arch> and
hw/<bus>, so the logic would be to have hw/net (also mimicking Linux's
drivers/net directory). It's premature to create hw/vmware, we risk
getting a spaghetti directory structure.
eth.c/eth.h sound more interesting. Could they be used by host-side
code (e.g. SLIRP or a TAP backend)? If so, they belong in net/ and
include/net. If not, they belong in hw/ (waiting for hw/net to be created).
Paolo
next prev parent reply other threads:[~2013-01-16 15:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 16:09 [Qemu-devel] [PATCH V9 0/5] VMXNET3 paravirtual NIC device implementation Dmitry Fleytman
2013-01-12 16:09 ` [Qemu-devel] [PATCH v9 1/5] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes Dmitry Fleytman
2013-01-16 14:27 ` Stefan Hajnoczi
2013-01-21 12:01 ` Dmitry Fleytman
2013-01-21 12:48 ` Markus Armbruster
2013-01-12 16:09 ` [Qemu-devel] [PATCH v9 2/5] Adding utility function net_checksum_add_iov() for iovec checksum calculation Dmitry Fleytman
2013-01-12 16:09 ` [Qemu-devel] [PATCH v9 3/5] Adding common definitions for VMWARE devices Dmitry Fleytman
2013-01-16 15:24 ` Stefan Hajnoczi
2013-01-21 12:16 ` Dmitry Fleytman
2013-01-12 16:09 ` [Qemu-devel] [PATCH v9 4/5] Adding packet abstraction for VMWARE network devices Dmitry Fleytman
2013-01-16 14:48 ` Stefan Hajnoczi
2013-01-16 15:33 ` Paolo Bonzini [this message]
2013-01-17 10:24 ` Stefan Hajnoczi
2013-01-21 12:07 ` Dmitry Fleytman
2013-01-12 16:09 ` [Qemu-devel] [PATCH v9 5/5] Adding VMXNET3 device implementation Dmitry Fleytman
2013-01-16 15:16 ` Stefan Hajnoczi
2013-01-21 12:06 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6C85C.5020109@redhat.com \
--to=pbonzini@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=dmitry@daynix.com \
--cc=lists@wiesinger.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).