From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename()
Date: Wed, 16 Jan 2013 08:53:05 -0700 [thread overview]
Message-ID: <50F6CCE1.4020503@redhat.com> (raw)
In-Reply-To: <1358346998-26328-9-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 929 bytes --]
On 01/16/2013 07:36 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qemu-log.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-log.c b/qemu-log.c
> index 64a1b88..1eadf1b 100644
> --- a/qemu-log.c
> +++ b/qemu-log.c
> @@ -21,10 +21,12 @@
> #include "qemu/log.h"
>
> #ifdef WIN32
> -static const char *logfilename = "qemu.log";
> +#define DEFAULT_LOGFILENAME = "qemu.log"
Syntax error.
> @@ -54,11 +56,13 @@ void qemu_log_mask(int mask, const char *fmt, ...)
> /* enable or disable low levels log */
> void qemu_set_log(int log_flags, bool use_own_buffers)
> {
> + const char *fname = logfilename ?: DEFAULT_LOGFILENAME;
?: is not C99, but a GNU extension. What is our policy on using it?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-01-16 15:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 14:36 [Qemu-devel] [PATCH 00/11] Trivial memory allocation fixes & cleanups Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 01/11] g_malloc(0) and g_malloc0(0) return NULL; simplify Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 02/11] g_strdup(NULL) returns " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 04/11] readline: " Markus Armbruster
2013-01-16 15:51 ` Eric Blake
2013-01-16 16:03 ` Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 05/11] spice: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 06/11] virtfs-proxy-helper: Fix unchecked strdup() by conv. " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 07/11] qemu-log: Fix unchecked strdup() by converting " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 08/11] qemu-log: Plug trivial memory leak in cpu_set_log_filename() Markus Armbruster
2013-01-16 15:53 ` Eric Blake [this message]
2013-01-16 16:06 ` Markus Armbruster
2013-01-17 20:49 ` Blue Swirl
2013-01-16 14:36 ` [Qemu-devel] [PATCH 09/11] libcacard: Fix unchecked strdup() by converting to g_strdup() Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 10/11] qapi: " Markus Armbruster
2013-01-16 14:36 ` [Qemu-devel] [PATCH 11/11] qemu-ga: " Markus Armbruster
2013-01-16 15:54 ` [Qemu-devel] [PATCH 00/11] Trivial memory allocation fixes & cleanups Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6CCE1.4020503@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).