From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58907) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWtv-00053Y-Un for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:35:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvWtt-0002Fi-TA for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:35:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWtt-0002Fb-Hp for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:35:45 -0500 Message-ID: <50F6E4EC.8030008@redhat.com> Date: Wed, 16 Jan 2013 10:35:40 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358353497-5292-1-git-send-email-benoit@irqsave.net> <1358353497-5292-15-git-send-email-benoit@irqsave.net> In-Reply-To: <1358353497-5292-15-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2PITAOVUBWXHQLITUGIPA" Subject: Re: [Qemu-devel] [RFC V5 14/36] qcow2: Load and save deduplication table header extension. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2PITAOVUBWXHQLITUGIPA Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2013 09:24 AM, Beno=C3=AEt Canet wrote: > Signed-off-by: Benoit Canet > --- > block/qcow2.c | 43 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) >=20 > + if (s->has_dedup) { > + memset(&dedup_table_extension, 0, sizeof(dedup_table_extension= )); > + dedup_table_extension.offset =3D cpu_to_be64(s->dedup_table_of= fset); > + dedup_table_extension.size =3D cpu_to_be32(s->dedup_table_size= ); > + dedup_table_extension.hash_algo =3D s->dedup_hash_algo; > + dedup_table_extension.strategies |=3D 1; /* RAM based lookup *= / > + dedup_table_extension.strategies |=3D 1 << 2; /* deduplication= running */ Magic numbers here; you should probably give these bits a symbolic name via #define or enum. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2PITAOVUBWXHQLITUGIPA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9uTsAAoJEKeha0olJ0NqPUUH/3bVePpxx3bF9g36ywOnvHcv 6q/n74Hppn2Ni3IrUbiouY/F1QT1hoy0s5UEteJub9qiuMLRLK4LLB/XQ61g3hLl fhr/H/0sNg07WS9IV0LfWKxWKB9q7iRj0oKq6JhuwenoGxIqBSwr/T7xzXqd1Hs/ c6W9ewLjqxxMs56ZeFDbl9W02LCmdD9pfkvEJ5cq/suoweLIE9soSvE0NBx90AW8 CW3VCuuG18u5G+tpfp8mlHG3iiVlW7BPYSaJ79XQkLwl6lqaZZZkdigQX2fEdNjY ocIamMlz6rkEOdzo1+Lk3mo/zviTaH91lFNOazs8Pkq5dSSSxWCUbxo3c8e+rSA= =zQvs -----END PGP SIGNATURE----- ------enig2PITAOVUBWXHQLITUGIPA--