From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: fix Win32 clean build
Date: Wed, 16 Jan 2013 18:40:59 +0100 [thread overview]
Message-ID: <50F6E62B.7030308@redhat.com> (raw)
In-Reply-To: <50F59336.2060707@weilnetz.de>
Il 15/01/2013 18:34, Stefan Weil ha scritto:
>
> Tested-by: Stefan Weil <sw@weilnetz.de>
>
> Blue, Paolo's patch fixes a recently introduced build regression for MinGW.
> Please apply it to git master.
>
> I won't send a pull request because it is a build fix.
>
> Paolo, your latest modifications added one more regression
> because MinGW builds now compile files which are only needed
> for user mode (= never for MinGW).util/envlist.c uses strtok_r
> which is unavailable for MinGW, so we get a compiler warning,
> but no linker error because it is unused.
Yeah, this is a side effect of having an understandable directory
layout. :) However I'd prefer if we added strtok_r to oslib-win32.c to
silence the warning, even if it's dead code.
Paolo
next prev parent reply other threads:[~2013-01-16 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 8:49 [Qemu-devel] [PATCH] build: fix Win32 clean build Paolo Bonzini
2013-01-15 17:34 ` Stefan Weil
2013-01-16 17:40 ` Paolo Bonzini [this message]
2013-01-16 21:14 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6E62B.7030308@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).