From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWz7-0004JS-MW for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:41:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvWz6-0003jB-Mw for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:41:09 -0500 Received: from mail-ia0-x22c.google.com ([2607:f8b0:4001:c02::22c]:65162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvWz6-0003j6-IV for qemu-devel@nongnu.org; Wed, 16 Jan 2013 12:41:08 -0500 Received: by mail-ia0-f172.google.com with SMTP id u8so190375iag.31 for ; Wed, 16 Jan 2013 09:41:07 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50F6E62B.7030308@redhat.com> Date: Wed, 16 Jan 2013 18:40:59 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1358239777-29911-2-git-send-email-pbonzini@redhat.com> <50F59336.2060707@weilnetz.de> In-Reply-To: <50F59336.2060707@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] build: fix Win32 clean build List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , qemu-devel@nongnu.org Il 15/01/2013 18:34, Stefan Weil ha scritto: > > Tested-by: Stefan Weil > > Blue, Paolo's patch fixes a recently introduced build regression for MinGW. > Please apply it to git master. > > I won't send a pull request because it is a build fix. > > Paolo, your latest modifications added one more regression > because MinGW builds now compile files which are only needed > for user mode (= never for MinGW).util/envlist.c uses strtok_r > which is unavailable for MinGW, so we get a compiler warning, > but no linker error because it is unused. Yeah, this is a side effect of having an understandable directory layout. :) However I'd prefer if we added strtok_r to oslib-win32.c to silence the warning, even if it's dead code. Paolo