From: Kevin Wolf <kwolf@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll()
Date: Wed, 16 Jan 2013 19:27:55 +0100 [thread overview]
Message-ID: <50F6F12B.4070407@redhat.com> (raw)
In-Reply-To: <1358360751-1745-1-git-send-email-kwolf@redhat.com>
Am 16.01.2013 19:25, schrieb Kevin Wolf:
> aio_poll() must return true if any work is still pending, even if it
> didn't make progress, so that bdrv_drain_all() doesn't stop waiting too
> early. The possibility of stopping early occasionally lead to a failed
> assertion in bdrv_drain_all(), when some in-flight request was missed
> and the function didn't really drain all requests.
>
> In order to make that change, the return value as specified in the
> function comment must change for blocking = false; fortunately, the
> return value of blocking = false callers is only used in test cases, so
> this change shouldn't cause any trouble.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Argh, sent the wrong file. Stefan, can you please replace "aio-posix" by
"aio" in the subject line before applying?
Kevin
next prev parent reply other threads:[~2013-01-16 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 18:25 [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll() Kevin Wolf
2013-01-16 18:27 ` Kevin Wolf [this message]
2013-01-17 9:56 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F6F12B.4070407@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).