From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TvXiS-0008WH-TP for qemu-devel@nongnu.org; Wed, 16 Jan 2013 13:28:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TvXiR-0008U9-PG for qemu-devel@nongnu.org; Wed, 16 Jan 2013 13:28:00 -0500 Message-ID: <50F6F12B.4070407@redhat.com> Date: Wed, 16 Jan 2013 19:27:55 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1358360751-1745-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1358360751-1745-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org Am 16.01.2013 19:25, schrieb Kevin Wolf: > aio_poll() must return true if any work is still pending, even if it > didn't make progress, so that bdrv_drain_all() doesn't stop waiting too > early. The possibility of stopping early occasionally lead to a failed > assertion in bdrv_drain_all(), when some in-flight request was missed > and the function didn't really drain all requests. > > In order to make that change, the return value as specified in the > function comment must change for blocking = false; fortunately, the > return value of blocking = false callers is only used in test cases, so > this change shouldn't cause any trouble. > > Cc: qemu-stable@nongnu.org > Signed-off-by: Kevin Wolf Argh, sent the wrong file. Stefan, can you please replace "aio-posix" by "aio" in the subject line before applying? Kevin