From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvbyg-000556-SA for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:01:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvbyf-0000pI-K2 for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:01:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvbyf-0000p4-Bh for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:01:01 -0500 Message-ID: <50F730FA.9040007@redhat.com> Date: Wed, 16 Jan 2013 16:00:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358353518-5421-1-git-send-email-benoit@irqsave.net> <1358353518-5421-11-git-send-email-benoit@irqsave.net> In-Reply-To: <1358353518-5421-11-git-send-email-benoit@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2SDFARUKMKAKFDBLWMWHT" Subject: Re: [Qemu-devel] [RFC V1 10/12] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2SDFARUKMKAKFDBLWMWHT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2013 09:25 AM, Beno=C3=AEt Canet wrote: > --- > include/qapi/qmp/qerror.h | 3 +++ > 1 file changed, 3 insertions(+) You don't want this patch; instead, code in later patches that currently uses error_set(errp, QERR_DEVICE_NOT_DEDUPLICATED, bdrv_get_device_name(bs)); should instead call error_setg(errp, "Device '%s' doesn't support deduplication", bdrv_get_device_name(bs)); --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2SDFARUKMKAKFDBLWMWHT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9zD6AAoJEKeha0olJ0NqnGMH/RdtKLL6Y2V+yc1n8wSxCAxt D7a9ClsbXlPRrCR4KDLBzRK4GYbOANRZ7ELVOEeptQjXR2vqEbBJ2PSN9iOPp6+W pxDJnuOcBmiwKsdTs6M6Y0dpYgVO6DhvVtPc8njDM7AIktVKGP2rh0r9h+UJhnms 0hq0SLleQcDVZUoOTvaqJoyX1JggNXka8D/MjC4x5My8qlSOlS/ZY59TqVhG054f 0dO4w076MfiUyVgdpgIuJ6CmJ03Ocv5MeSVTLMTXqB+7ysLeJcYVQ5i+cWUOY/aY tLUUvgQdJjnD7zevXtKIh5gc9W6NoKf81/3/c6HUbGkyvyDlQIL8yOjyEdD045E= =R4Ds -----END PGP SIGNATURE----- ------enig2SDFARUKMKAKFDBLWMWHT--