From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvcf8-000219-Ck for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:44:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tvcf7-0006IA-8q for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:44:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tvcf6-0006Hy-Vi for qemu-devel@nongnu.org; Wed, 16 Jan 2013 18:44:53 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0GNipkT008864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 16 Jan 2013 18:44:52 -0500 Message-ID: <50F73B72.9020704@redhat.com> Date: Wed, 16 Jan 2013 16:44:50 -0700 From: Eric Blake MIME-Version: 1.0 References: <1358357479-7912-1-git-send-email-pbonzini@redhat.com> <1358357479-7912-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1358357479-7912-9-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2FWLRWFTBLTSGCDPPADCX" Subject: Re: [Qemu-devel] [PATCH v2 08/12] mirror: allow customizing the granularity List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2FWLRWFTBLTSGCDPPADCX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/16/2013 10:31 AM, Paolo Bonzini wrote: > The desired granularity may be very different depending on the kind of > operation (e.g. continuous replication vs. collapse-to-raw) and whether= > the VM is expected to perform lots of I/O while mirroring is in progres= s. >=20 > Allow the user to customize it, while providing a sane default so that > in general there will be no extra allocated space in the target compare= d > to the source. >=20 > +++ b/qapi-schema.json > @@ -1636,6 +1636,11 @@ > # (all the disk, only the sectors allocated in the topmost imag= e, or > # only new I/O). > # > +# @granularity: #optional granularity of the dirty bitmap, default is = 64K > +# if the image format doesn't have clusters, 4K if the c= lusters > +# are smaller than that, else the cluster size. Must be= a > +# power of 2 between 512 and 64M. Mention that granularity was only added in 1.4. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2FWLRWFTBLTSGCDPPADCX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJQ9ztyAAoJEKeha0olJ0NqgBAH/1N3xORIp1LlaYOaun8Ccel+ Tqa7sdHVeyO+BMvtnoWQa5sY7AeYlRQ3VO0R1lk87cBUM9wBnXQBcNHZMJFE3Y4Q 3upEIge4XD8ecq6aAbiw6QHPAVTxhlCHMGgZ0II+k9L8MXp/9jEGlp/IFfjesVsO rvn1ZU0B/Kx7SvejBpikvI6NwcXjxsl+K1Yw0IUrDSdjO7wozW5uIAoCEuEAaUC1 HD/sVJ92Zjl5d6iletWY+1a33GG1YoC0tDd5WH4rA5hDvdkkQMGbQUfsbOwyNQXj M90x5rQqPLxgrJlUoy5Ru3WMd6kN858W4BvG3sKoEZ+FFdh033BQSH0KGPAQJD8= =1waJ -----END PGP SIGNATURE----- ------enig2FWLRWFTBLTSGCDPPADCX--