Re: [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On 01/16/2013 10:31 AM, Paolo Bonzini wrote:
> The fixes from the previous post are:
> 
> 1) the in_flight_bitmap is now properly set and cleared [Stefan];
> 
> 2) persistent dirty bitmap left out [Stefan];
> 
> 3) reordered arguments in qmp-command.hx to follow patch order [Stefan];
> 
> 4) tests/qemu-iotests/041.out is regenerated;
> 
> 5) rebased for moved include files and for the discard series
> 
> Thanks!

The series still looks okay to me.  I pointed out a few potential
improvements to qapi-schema.json (basically, for any structure that
existed in 1.3 or earlier, the additional fields added in this series
should mention that they were added in 1.4); but I could live with a
single cleanup patch 13/12 that does that all at once, instead of
needing a v3 respin of these patches.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]