From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38930)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tvoj2-0006jJ-Ia
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 07:37:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tvoiy-0004Vt-Ir
	for qemu-devel@nongnu.org; Thu, 17 Jan 2013 07:37:44 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50F7D828.7090302@redhat.com>
Date: Thu, 17 Jan 2013 11:53:28 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1358367600-8074-1-git-send-email-kwolf@redhat.com>
In-Reply-To: <1358367600-8074-1-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, qemu-stable@nongnu.org

Il 16/01/2013 21:19, Kevin Wolf ha scritto:
> Paolo, especially the first one is worrying with respect to the test status of
> this code. We should probably give it some additional testing.
> 
> Kevin Wolf (2):
>   win32-aio: Fix vectored reads
>   win32-aio: Fix memory leak
> 
>  block/win32-aio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 

Yes, the worrying part is especially that IIUC qtest does not support
Windows.  There's no way to get good coverage without qtest.

Paolo