From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/4] block/vdi: Improved return values from vdi_open and other small fixes
Date: Thu, 17 Jan 2013 13:08:12 +0100 [thread overview]
Message-ID: <50F7E9AC.9040207@redhat.com> (raw)
In-Reply-To: <1355580573-19323-5-git-send-email-sw@weilnetz.de>
Am 15.12.2012 15:09, schrieb Stefan Weil:
> vdi_open returned -1 in case of any error, but it should return an
> error code (negative value of errno or BDRV_WRONG_FORMAT).
>
> vdi_open did not check for a bad signature. This check was only in vdi_probe.
>
> The signature is a 32 bit value and needs up to 8 hex digits for printing.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Sounds like three independent changes and should be three patches therefore.
Kevin
next prev parent reply other threads:[~2013-01-17 12:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 14:09 [Qemu-devel] [PATCH 0/4] block: Fix error report for wrong file format Stefan Weil
2012-12-15 14:09 ` [Qemu-devel] [PATCH 1/4] block: Add special error code for wrong format Stefan Weil
2012-12-18 14:34 ` Stefan Hajnoczi
2013-01-17 12:01 ` Kevin Wolf
2012-12-15 14:09 ` [Qemu-devel] [PATCH 2/4] block: Improve error report " Stefan Weil
2012-12-17 15:08 ` Luiz Capitulino
2012-12-15 14:09 ` [Qemu-devel] [PATCH 3/4] block: Use new error code for wrong format in selected block drivers Stefan Weil
2012-12-15 15:54 ` Don Slutz
2012-12-15 14:09 ` [Qemu-devel] [PATCH 4/4] block/vdi: Improved return values from vdi_open and other small fixes Stefan Weil
2013-01-17 12:08 ` Kevin Wolf [this message]
2013-01-16 18:53 ` [Qemu-devel] [PATCH 0/4] block: Fix error report for wrong file format Stefan Weil
2013-01-17 8:33 ` Stefan Hajnoczi
2013-01-17 12:10 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F7E9AC.9040207@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).